Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/data-source/aws_pricing_product: Remove hardcoded us-east-1 handling #16040

Merged
merged 1 commit into from
Nov 11, 2020
Merged

tests/data-source/aws_pricing_product: Remove hardcoded us-east-1 handling #16040

merged 1 commit into from
Nov 11, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #8316
Reference: #15737

Release note for CHANGELOG:

NONE

Previously in AWS GovCloud (US):

=== CONT  TestAccDataSourceAwsPricingProduct_ec2
TestAccDataSourceAwsPricingProduct_ec2: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: bc4d07ae-04d0-4fad-b695-5ef067be32ee  []}]
--- FAIL: TestAccDataSourceAwsPricingProduct_ec2 (0.41s)

=== CONT  TestAccDataSourceAwsPricingProduct_redshift
TestAccDataSourceAwsPricingProduct_redshift: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: 0871bc77-35ba-4dbe-aa49-7a54304986ce  []}]
--- FAIL: TestAccDataSourceAwsPricingProduct_redshift (0.38s)

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccDataSourceAwsPricingProduct_ec2 (18.23s)
--- PASS: TestAccDataSourceAwsPricingProduct_redshift (18.42s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccDataSourceAwsPricingProduct_ec2 (1.54s)
--- SKIP: TestAccDataSourceAwsPricingProduct_redshift (1.54s)

@bflad
tests/data-source/aws_pricing_product: Remove hardcoded us-east-1 han…
51a46ec 
…dling

Reference: #8316
Reference: #15737

Previously in AWS GovCloud (US):

```
=== CONT  TestAccDataSourceAwsPricingProduct_ec2
TestAccDataSourceAwsPricingProduct_ec2: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: bc4d07ae-04d0-4fad-b695-5ef067be32ee  []}]
--- FAIL: TestAccDataSourceAwsPricingProduct_ec2 (0.41s)

=== CONT  TestAccDataSourceAwsPricingProduct_redshift
TestAccDataSourceAwsPricingProduct_redshift: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: 0871bc77-35ba-4dbe-aa49-7a54304986ce  []}]
--- FAIL: TestAccDataSourceAwsPricingProduct_redshift (0.38s)
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccDataSourceAwsPricingProduct_ec2 (18.23s)
--- PASS: TestAccDataSourceAwsPricingProduct_redshift (18.42s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccDataSourceAwsPricingProduct_ec2 (1.54s)
--- SKIP: TestAccDataSourceAwsPricingProduct_redshift (1.54s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 5, 2020
@bflad bflad requested a review from a team as a code owner November 5, 2020 02:00
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/pricing Issues and PRs that pertain to the pricing service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 5, 2020
@YakDriver YakDriver self-assigned this Nov 10, 2020
@YakDriver
Copy link
Member

Looking good on commercial:

--- PASS: TestAccDataSourceAwsPricingProduct_redshift (23.79s)
--- PASS: TestAccDataSourceAwsPricingProduct_ec2 (23.89s)

YakDriver
YakDriver approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! GovCloud:

    provider_test.go:626: skipping tests; partition aws-us-gov does not support api.pricing service
--- SKIP: TestAccDataSourceAwsPricingProduct_redshift (1.52s)
--- SKIP: TestAccDataSourceAwsPricingProduct_ec2 (1.52s)

@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Nov 11, 2020
@bflad bflad added this to the v3.15.0 milestone Nov 11, 2020
@bflad bflad merged commit 1bc1592 into master Nov 11, 2020
@bflad bflad deleted the t-aws_pricing_product-remove-hardcoded-region branch November 11, 2020 00:51
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/pricing Issues and PRs that pertain to the pricing service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @YakDriver