-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_imagebuilder_infrastructure_configuration #16186
New Resource: aws_imagebuilder_infrastructure_configuration #16186
Conversation
…hub.com/blckct/terraform-provider-aws into f-aws_imagebuilder_infrastructure_configuration
Reference: #11084 Reference: #13485 Reference: #14347 Changes: ``` * **New Data Source:** `aws_imagebuilder_infrastructure_configuration` * **New Resource:** `aws_imagebuilder_infrastructure_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (47.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (56.76s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (34.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (75.52s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (63.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (63.67s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (82.86s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (76.12s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (62.22s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (76.90s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.00s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (76.21s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (74.09s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (62.45s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (26.62s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (51.08s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (66.77s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (44.79s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (76.02s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (71.91s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (73.11s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (88.93s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (84.10s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (71.55s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (81.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.43s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (83.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (87.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (71.96s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (33.51s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 14:24:06 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 14:24:06 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-west-2) 2020/11/13 14:24:09 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration 2020/11/13 14:24:09 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 14:24:09 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-east-1) 2020/11/13 14:24:11 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.692s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 14:24:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 14:24:10 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-gov-west-1) 2020/11/13 14:24:12 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.976s ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
A couple cases of fmt.Errorf("...%s", ..., err)
Commercial partition:
--- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (65.58s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (72.59s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (77.72s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (112.74s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (115.55s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (115.97s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (116.69s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (117.87s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (118.52s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (118.67s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (118.98s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (119.07s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (123.75s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (124.57s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (129.95s)
GovCloud partition:
Pending
This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Reference: #11084
Reference: #13485
Reference: #14347
Release note for CHANGELOG:
Output from acceptance testing in AWS Commercial:
Output from acceptance testing in AWS GovCloud (US):
Output from sweeper in AWS Commercial:
Output from sweeper in AWS GovCloud (US):