Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_acm_certificate: Migrate to SDK TypeSet function #16217

Merged
merged 1 commit into from
Nov 27, 2020
Merged

tests/resource/aws_acm_certificate: Migrate to SDK TypeSet function #16217

merged 1 commit into from
Nov 27, 2020

Conversation

mattburgess
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15882

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAcmCertificate'
=== RUN   TestAccAWSAcmCertificateDataSource_singleIssued
--- SKIP: TestAccAWSAcmCertificateDataSource_singleIssued (0.00s)
=== RUN   TestAccAWSAcmCertificateDataSource_multipleIssued
--- SKIP: TestAccAWSAcmCertificateDataSource_multipleIssued (0.00s)
=== RUN   TestAccAWSAcmCertificateDataSource_noMatchReturnsError
--- SKIP: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (0.00s)
=== RUN   TestAccAWSAcmCertificateDataSource_KeyTypes
=== PAUSE TestAccAWSAcmCertificateDataSource_KeyTypes
=== RUN   TestAccAWSAcmCertificate_emailValidation
--- SKIP: TestAccAWSAcmCertificate_emailValidation (0.00s)
=== RUN   TestAccAWSAcmCertificate_dnsValidation
--- SKIP: TestAccAWSAcmCertificate_dnsValidation (0.00s)
=== RUN   TestAccAWSAcmCertificate_root
--- SKIP: TestAccAWSAcmCertificate_root (0.00s)
=== RUN   TestAccAWSAcmCertificate_privateCert
=== PAUSE TestAccAWSAcmCertificate_privateCert
=== RUN   TestAccAWSAcmCertificate_root_TrailingPeriod
--- SKIP: TestAccAWSAcmCertificate_root_TrailingPeriod (0.00s)
=== RUN   TestAccAWSAcmCertificate_rootAndWildcardSan
--- SKIP: TestAccAWSAcmCertificate_rootAndWildcardSan (0.00s)
=== RUN   TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString
--- SKIP: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (0.00s)
=== RUN   TestAccAWSAcmCertificate_san_single
--- SKIP: TestAccAWSAcmCertificate_san_single (0.00s)
=== RUN   TestAccAWSAcmCertificate_san_multiple
--- SKIP: TestAccAWSAcmCertificate_san_multiple (0.00s)
=== RUN   TestAccAWSAcmCertificate_san_TrailingPeriod
--- SKIP: TestAccAWSAcmCertificate_san_TrailingPeriod (0.00s)
=== RUN   TestAccAWSAcmCertificate_wildcard
--- SKIP: TestAccAWSAcmCertificate_wildcard (0.00s)
=== RUN   TestAccAWSAcmCertificate_wildcardAndRootSan
--- SKIP: TestAccAWSAcmCertificate_wildcardAndRootSan (0.00s)
=== RUN   TestAccAWSAcmCertificate_disableCTLogging
--- SKIP: TestAccAWSAcmCertificate_disableCTLogging (0.00s)
=== RUN   TestAccAWSAcmCertificate_tags
--- SKIP: TestAccAWSAcmCertificate_tags (0.00s)
=== RUN   TestAccAWSAcmCertificate_imported_DomainName
=== PAUSE TestAccAWSAcmCertificate_imported_DomainName
=== RUN   TestAccAWSAcmCertificate_imported_IpAddress
=== PAUSE TestAccAWSAcmCertificate_imported_IpAddress
=== RUN   TestAccAWSAcmCertificate_PrivateKey_Tags
=== PAUSE TestAccAWSAcmCertificate_PrivateKey_Tags
=== RUN   TestAccAWSAcmCertificateValidation_basic
--- SKIP: TestAccAWSAcmCertificateValidation_basic (0.00s)
=== RUN   TestAccAWSAcmCertificateValidation_timeout
--- SKIP: TestAccAWSAcmCertificateValidation_timeout (0.00s)
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdns
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdns (0.00s)
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (0.00s)
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (0.00s)
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (0.00s)
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (0.00s)
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (0.00s)
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (0.00s)
=== CONT  TestAccAWSAcmCertificateDataSource_KeyTypes
=== CONT  TestAccAWSAcmCertificate_imported_IpAddress
=== CONT  TestAccAWSAcmCertificate_imported_DomainName
=== CONT  TestAccAWSAcmCertificate_PrivateKey_Tags
=== CONT  TestAccAWSAcmCertificate_privateCert
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (23.97s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (33.26s)
--- PASS: TestAccAWSAcmCertificate_privateCert (33.08s)
--- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (42.39s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (71.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	72.963s

@mattburgess mattburgess requested a review from a team as a code owner November 16, 2020 20:49
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/acm Issues and PRs that pertain to the acm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 16, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 16, 2020
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @mattburgess for the contribution!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSAcmCertificate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAcmCertificate -timeout 120m
=== RUN   TestAccAWSAcmCertificateDataSource_singleIssued
=== PAUSE TestAccAWSAcmCertificateDataSource_singleIssued
=== RUN   TestAccAWSAcmCertificateDataSource_multipleIssued
=== PAUSE TestAccAWSAcmCertificateDataSource_multipleIssued
=== RUN   TestAccAWSAcmCertificateDataSource_noMatchReturnsError
=== PAUSE TestAccAWSAcmCertificateDataSource_noMatchReturnsError
=== RUN   TestAccAWSAcmCertificateDataSource_KeyTypes
=== PAUSE TestAccAWSAcmCertificateDataSource_KeyTypes
=== RUN   TestAccAWSAcmCertificate_emailValidation
=== PAUSE TestAccAWSAcmCertificate_emailValidation
=== RUN   TestAccAWSAcmCertificate_dnsValidation
=== PAUSE TestAccAWSAcmCertificate_dnsValidation
=== RUN   TestAccAWSAcmCertificate_root
=== PAUSE TestAccAWSAcmCertificate_root
=== RUN   TestAccAWSAcmCertificate_privateCert
=== PAUSE TestAccAWSAcmCertificate_privateCert
=== RUN   TestAccAWSAcmCertificate_root_TrailingPeriod
=== PAUSE TestAccAWSAcmCertificate_root_TrailingPeriod
=== RUN   TestAccAWSAcmCertificate_rootAndWildcardSan
=== PAUSE TestAccAWSAcmCertificate_rootAndWildcardSan
=== RUN   TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString
=== PAUSE TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString
=== RUN   TestAccAWSAcmCertificate_san_single
=== PAUSE TestAccAWSAcmCertificate_san_single
=== RUN   TestAccAWSAcmCertificate_san_multiple
=== PAUSE TestAccAWSAcmCertificate_san_multiple
=== RUN   TestAccAWSAcmCertificate_san_TrailingPeriod
=== PAUSE TestAccAWSAcmCertificate_san_TrailingPeriod
=== RUN   TestAccAWSAcmCertificate_wildcard
=== PAUSE TestAccAWSAcmCertificate_wildcard
=== RUN   TestAccAWSAcmCertificate_wildcardAndRootSan
=== PAUSE TestAccAWSAcmCertificate_wildcardAndRootSan
=== RUN   TestAccAWSAcmCertificate_disableCTLogging
=== PAUSE TestAccAWSAcmCertificate_disableCTLogging
=== RUN   TestAccAWSAcmCertificate_tags
=== PAUSE TestAccAWSAcmCertificate_tags
=== RUN   TestAccAWSAcmCertificate_imported_DomainName
=== PAUSE TestAccAWSAcmCertificate_imported_DomainName
=== RUN   TestAccAWSAcmCertificate_imported_IpAddress
=== PAUSE TestAccAWSAcmCertificate_imported_IpAddress
=== RUN   TestAccAWSAcmCertificate_PrivateKey_Tags
=== PAUSE TestAccAWSAcmCertificate_PrivateKey_Tags
=== RUN   TestAccAWSAcmCertificateValidation_basic
=== PAUSE TestAccAWSAcmCertificateValidation_basic
=== RUN   TestAccAWSAcmCertificateValidation_timeout
=== PAUSE TestAccAWSAcmCertificateValidation_timeout
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdns
=== PAUSE TestAccAWSAcmCertificateValidation_validationRecordFqdns
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail
=== PAUSE TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot
=== PAUSE TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard
=== PAUSE TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan
=== PAUSE TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard
=== PAUSE TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard
=== RUN   TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot
=== PAUSE TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot
=== CONT  TestAccAWSAcmCertificateDataSource_singleIssued
=== CONT  TestAccAWSAcmCertificate_disableCTLogging
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdns
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard
=== CONT  TestAccAWSAcmCertificateValidation_timeout
=== CONT  TestAccAWSAcmCertificateValidation_basic
=== CONT  TestAccAWSAcmCertificate_PrivateKey_Tags
=== CONT  TestAccAWSAcmCertificate_imported_IpAddress
=== CONT  TestAccAWSAcmCertificate_imported_DomainName
=== CONT  TestAccAWSAcmCertificate_tags
=== CONT  TestAccAWSAcmCertificate_root_TrailingPeriod
=== CONT  TestAccAWSAcmCertificate_wildcardAndRootSan
=== CONT  TestAccAWSAcmCertificate_wildcard
=== CONT  TestAccAWSAcmCertificate_san_TrailingPeriod
=== CONT  TestAccAWSAcmCertificate_san_multiple
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail
2020/11/27 08:20:49 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (3.13s)
=== CONT  TestAccAWSAcmCertificate_san_single
=== CONT  TestAccAWSAcmCertificateDataSource_singleIssued
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard
=== CONT  TestAccAWSAcmCertificateValidation_basic
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot
=== CONT  TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot
=== CONT  TestAccAWSAcmCertificate_rootAndWildcardSan
=== CONT  TestAccAWSAcmCertificate_emailValidation
=== CONT  TestAccAWSAcmCertificate_privateCert
=== CONT  TestAccAWSAcmCertificate_root
=== CONT  TestAccAWSAcmCertificate_dnsValidation
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard
    resource_aws_acm_certificate_validation_test.go:164: Step 1/1 error: Error running pre-apply refresh: 2020/11/27 08:20:48 [DEBUG] Using modified 
2020/11/27 08:20:51 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
=== CONT  TestAccAWSAcmCertificateDataSource_noMatchReturnsError
--- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (1.81s)
=== CONT  TestAccAWSAcmCertificateDataSource_KeyTypes
2020/11/27 08:20:52 [DEBUG] Trying to get account information via sts:GetCallerIdentity
=== CONT  TestAccAWSAcmCertificateValidation_validationRecordFqdns
2020/11/27 08:21:02 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
--- PASS: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (11.35s)
=== CONT  TestAccAWSAcmCertificateDataSource_multipleIssued
2020/11/27 08:21:02 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (17.86s)
=== CONT  TestAccAWSAcmCertificateDataSource_multipleIssued
    data_source_aws_acm_certificate_test.go:110: Step 1/6, expected an error with pattern, no match on: Error running pre-apply refresh: 2020/11/27 08:21:03 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
2020/11/27 08:21:05 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (20.60s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (20.92s)
2020/11/27 08:21:08 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/11/27 08:21:08 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/11/27 08:21:08 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (22.72s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (17.77s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (23.64s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (23.80s)
--- PASS: TestAccAWSAcmCertificate_san_single (20.68s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (20.60s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (20.76s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (25.58s)
--- PASS: TestAccAWSAcmCertificate_root (21.01s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (22.42s)
--- PASS: TestAccAWSAcmCertificate_privateCert (22.52s)
--- PASS: TestAccAWSAcmCertificate_wildcard (28.10s)
--- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (31.23s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (43.69s)
--- PASS: TestAccAWSAcmCertificate_tags (65.29s)

@breathingdust breathingdust added this to the v3.19.0 milestone Nov 27, 2020
@breathingdust breathingdust merged commit 79e4383 into hashicorp:master Nov 27, 2020
@ghost
Copy link

ghost commented Dec 1, 2020

This has been released in version 3.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 27, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/acm Issues and PRs that pertain to the acm service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mattburgess @breathingdust