Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove "id" fields from schema definitions #1626

Merged
merged 3 commits into from
Oct 26, 2017
Merged

remove "id" fields from schema definitions #1626

merged 3 commits into from
Oct 26, 2017

Commits on Sep 8, 2017

  1. remove "id" fields from schema definitions 

    The "id" field is built-in and not required in the schema. Future
updates to helper/schema will cause these to fail validation.
    @jbardin
    jbardin committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    6bfc1c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2017

  1. replace Set and Get of "id" with Id and SetId 

    Replace Set and Get with "id" keys with SetId and Id, and remove
redundant uses of these.

Remove a few more stray "id" fields in schemas. The few remaining are
not at the top level and don't represent "resources" in their own.
    @jbardin
    jbardin committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    37da2b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2017

  1. Put Optional 'id' fields back to data sources

    @radeksimko
    radeksimko committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    ac556d7 View commit details
    Browse the repository at this point in the history