Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudfront_distribution: Use flattenStringSet helper #16280

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Nov 18, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6867

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceCloudFrontDistribution'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSourceCloudFrontDistribution -timeout 120m
=== RUN   TestAccAWSDataSourceCloudFrontDistribution_basic
=== PAUSE TestAccAWSDataSourceCloudFrontDistribution_basic
=== CONT  TestAccAWSDataSourceCloudFrontDistribution_basic
--- PASS: TestAccAWSDataSourceCloudFrontDistribution_basic (349.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	350.003s

@mattburgess mattburgess requested a review from a team as a code owner November 18, 2020 15:34
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Nov 18, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 18, 2020
@anGie44 anGie44 added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 3, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mattburgess 🚀

@anGie44 anGie44 added this to the v3.20.0 milestone Dec 3, 2020
@anGie44 anGie44 merged commit 46c0cb8 into hashicorp:master Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants