resource/codedeploy_deployment_group: Use flattenStringSet helper

[mattburgess]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6867

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeDeployDeploymentGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSCodeDeployDeploymentGroup -timeout 120m
=== RUN   TestAccAWSCodeDeployDeploymentGroup_basic
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_basic
=== RUN   TestAccAWSCodeDeployDeploymentGroup_basic_tagSet
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_basic_tagSet
=== RUN   TestAccAWSCodeDeployDeploymentGroup_onPremiseTag
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_onPremiseTag
=== RUN   TestAccAWSCodeDeployDeploymentGroup_disappears
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_disappears
=== RUN   TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic
=== RUN   TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple
=== RUN   TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create
=== RUN   TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update
=== RUN   TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete
=== RUN   TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable
=== RUN   TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create
=== RUN   TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update
=== RUN   TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete
=== RUN   TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable
=== RUN   TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default
=== RUN   TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create
=== RUN   TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update
=== RUN   TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete
=== RUN   TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create
=== RUN   TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update
=== RUN   TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete
=== RUN   TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create
=== RUN   TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update
=== RUN   TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete
=== RUN   TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_create
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_create
=== RUN   TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_update
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_update
=== RUN   TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create
=== RUN   TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg
=== RUN   TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update
=== RUN   TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete
=== RUN   TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete
=== RUN   TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen
=== CONT  TestAccAWSCodeDeployDeploymentGroup_basic
=== CONT  TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete
=== CONT  TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_update (36.07s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (36.14s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (56.01s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (41.06s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (41.28s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (31.15s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (22.39s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (41.67s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (40.80s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (32.30s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (31.93s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (35.12s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (42.01s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (41.68s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (30.92s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (30.35s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_create (30.42s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_onPremiseTag
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (41.33s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (33.77s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (22.56s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (41.49s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (41.83s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg
    TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg: resource_aws_codedeploy_deployment_group_test.go:1247: Step 1/2 error: Error running pre-apply refresh: 
        Error: no matching subnet found
        
        
--- FAIL: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg (2.34s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (41.07s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (39.25s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create
    TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create: resource_aws_codedeploy_deployment_group_test.go:1193: Step 1/2 error: Error running pre-apply refresh: 
        Error: no matching subnet found
        
        
--- FAIL: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (2.65s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (33.65s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_disappears
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (41.28s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_basic_tagSet
--- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (31.35s)
=== CONT  TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (51.45s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (31.68s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen (268.72s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	514.380s
FAIL
make: *** [GNUmakefile:28: testacc] Error 1

The failures here are latent; they happen against current master too.

[anGie44]

Changes here look great @mattburgess 👍 Only thing are the CI checks failing but I believe if you rebase when you have a chance they should clear up.

[ghost]

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!