Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/networkfirewall_firewall: add vpc endpoint information (FirewallStatus) #16399

Merged
merged 2 commits into from
Nov 25, 2020
Merged

resource/networkfirewall_firewall: add vpc endpoint information (FirewallStatus) #16399

merged 2 commits into from
Nov 25, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Nov 24, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16350

Release note for CHANGELOG:

resource/networkfirewall_firewall: add `firewall_status` argument

Output from acceptance testing:

--- PASS: TestAccAwsNetworkFirewallFirewall_basic (700.66s)
--- PASS: TestAccAwsNetworkFirewallFirewall_subnetMappings_updateSubnet (1281.57s)
--- PASS: TestAccAwsNetworkFirewallFirewall_subnetMappings_updateMultipleSubnets (1353.09s)

@anGie44 anGie44 requested a review from a team as a code owner November 24, 2020 05:35
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 24, 2020
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 24, 2020
@anGie44 anGie44 force-pushed the f-network-firewall-vpc-endpoints branch from 873a318 to cd414f5 Compare November 24, 2020 05:43
anGie44
anGie44 commented Nov 24, 2020
View reviewed changes
aws/internal/service/networkfirewall/waiter/waiter.go Outdated
@@ -40,6 +40,7 @@ func FirewallUpdated(ctx context.Context, conn *networkfirewall.NetworkFirewall,
Target: []string{networkfirewall.FirewallStatusValueReady},
Refresh: FirewallUpdatedStatus(ctx, conn, arn),
Timeout: FirewallTimeout,
Delay: 30 * time.Second,
Copy link
Contributor Author

@anGie44 anGie44 Nov 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to account for Associate/DisassociateSubnet calls that return a Ready status immediately after method is called instead of immediately returning Provisioning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add this as a code comment. 😄

@anGie44 anGie44 force-pushed the f-network-firewall-vpc-endpoints branch from cd414f5 to 13a9edb Compare November 24, 2020 06:26
@bflad bflad self-assigned this Nov 25, 2020
bflad
bflad reviewed Nov 25, 2020
View reviewed changes
aws/internal/service/networkfirewall/waiter/waiter.go Outdated
@@ -40,6 +40,7 @@ func FirewallUpdated(ctx context.Context, conn *networkfirewall.NetworkFirewall,
Target: []string{networkfirewall.FirewallStatusValueReady},
Refresh: FirewallUpdatedStatus(ctx, conn, arn),
Timeout: FirewallTimeout,
Delay: 30 * time.Second,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add this as a code comment. 😄

aws/resource_aws_networkfirewall_firewall.go Show resolved Hide resolved
aws/resource_aws_networkfirewall_firewall.go Outdated Show resolved Hide resolved
website/docs/r/networkfirewall_firewall.html.markdown Outdated Show resolved Hide resolved
@anGie44 anGie44 force-pushed the f-network-firewall-vpc-endpoints branch from a732a65 to 754d215 Compare November 25, 2020 19:20
@anGie44
Copy link
Contributor Author

anGie44 commented Nov 25, 2020 •
edited
Loading

Output of acceptance tests after changes:

--- PASS: TestAccAwsNetworkFirewallFirewall_basic (505.79s)
--- PASS: TestAccAwsNetworkFirewallFirewall_subnetMappings_updateSubnet (1286.15s)

@bflad bflad added this to the v3.18.0 milestone Nov 25, 2020
bflad
bflad approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Output from acceptance testing:

--- PASS: TestAccAwsNetworkFirewallFirewall_disappears (733.96s)
--- PASS: TestAccAwsNetworkFirewallFirewall_basic (806.43s)
--- PASS: TestAccAwsNetworkFirewallFirewall_deleteProtection (927.22s)
--- PASS: TestAccAwsNetworkFirewallFirewall_description (970.18s)
--- PASS: TestAccAwsNetworkFirewallFirewall_tags (1002.60s)
--- PASS: TestAccAwsNetworkFirewallFirewall_subnetMappings_updateSubnet (1579.25s)

@anGie44 anGie44 merged commit 1c5dad9 into master Nov 25, 2020
@anGie44 anGie44 deleted the f-network-firewall-vpc-endpoints branch November 25, 2020 20:20
anGie44 added a commit that referenced this pull request Nov 25, 2020
@anGie44
Update CHANGELOG for #16399
50133d8
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.18.0
Development

Successfully merging this pull request may close these issues.

aws_networkfirewall_firewall - expose VPC endpoints to terraform
2 participants
@anGie44 @bflad