Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ebs_volume: gp3 volume scalable throughput #16517

Merged
merged 7 commits into from
Jan 19, 2021

Commits on Dec 1, 2020

  1. r/aws_ebs_volume: Add 'throughput' attribute.

    Acceptance test output:
    
    $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_ -timeout 120m
    === RUN   TestAccAWSEBSVolume_basic
    === PAUSE TestAccAWSEBSVolume_basic
    === RUN   TestAccAWSEBSVolume_updateAttachedEbsVolume
    === PAUSE TestAccAWSEBSVolume_updateAttachedEbsVolume
    === RUN   TestAccAWSEBSVolume_updateSize
    === PAUSE TestAccAWSEBSVolume_updateSize
    === RUN   TestAccAWSEBSVolume_updateType
    === PAUSE TestAccAWSEBSVolume_updateType
    === RUN   TestAccAWSEBSVolume_updateIops_Io1
    === PAUSE TestAccAWSEBSVolume_updateIops_Io1
    === RUN   TestAccAWSEBSVolume_updateIops_Io2
    === PAUSE TestAccAWSEBSVolume_updateIops_Io2
    === RUN   TestAccAWSEBSVolume_kmsKey
    === PAUSE TestAccAWSEBSVolume_kmsKey
    === RUN   TestAccAWSEBSVolume_NoIops
    === PAUSE TestAccAWSEBSVolume_NoIops
    === RUN   TestAccAWSEBSVolume_InvalidIopsForType
    === PAUSE TestAccAWSEBSVolume_InvalidIopsForType
    === RUN   TestAccAWSEBSVolume_withTags
    === PAUSE TestAccAWSEBSVolume_withTags
    === RUN   TestAccAWSEBSVolume_multiAttach
    === PAUSE TestAccAWSEBSVolume_multiAttach
    === RUN   TestAccAWSEBSVolume_outpost
    === PAUSE TestAccAWSEBSVolume_outpost
    === RUN   TestAccAWSEBSVolume_disappears
    === PAUSE TestAccAWSEBSVolume_disappears
    === CONT  TestAccAWSEBSVolume_basic
    === CONT  TestAccAWSEBSVolume_NoIops
    === CONT  TestAccAWSEBSVolume_disappears
    === CONT  TestAccAWSEBSVolume_outpost
    === CONT  TestAccAWSEBSVolume_multiAttach
    === CONT  TestAccAWSEBSVolume_withTags
    === CONT  TestAccAWSEBSVolume_InvalidIopsForType
    === CONT  TestAccAWSEBSVolume_updateIops_Io1
    === CONT  TestAccAWSEBSVolume_kmsKey
    === CONT  TestAccAWSEBSVolume_updateIops_Io2
    === CONT  TestAccAWSEBSVolume_updateSize
    === CONT  TestAccAWSEBSVolume_updateType
    === CONT  TestAccAWSEBSVolume_updateAttachedEbsVolume
    === CONT  TestAccAWSEBSVolume_outpost
        data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
    --- SKIP: TestAccAWSEBSVolume_outpost (2.30s)
    --- PASS: TestAccAWSEBSVolume_InvalidIopsForType (17.21s)
    --- PASS: TestAccAWSEBSVolume_disappears (48.51s)
    --- PASS: TestAccAWSEBSVolume_multiAttach (54.90s)
    --- PASS: TestAccAWSEBSVolume_NoIops (55.61s)
    --- PASS: TestAccAWSEBSVolume_withTags (59.70s)
    --- PASS: TestAccAWSEBSVolume_basic (59.80s)
    --- PASS: TestAccAWSEBSVolume_kmsKey (60.16s)
    --- PASS: TestAccAWSEBSVolume_updateIops_Io2 (86.60s)
    --- PASS: TestAccAWSEBSVolume_updateIops_Io1 (87.46s)
    --- PASS: TestAccAWSEBSVolume_updateSize (87.58s)
    --- PASS: TestAccAWSEBSVolume_updateType (88.66s)
    --- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (187.70s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	187.763s
    ewbankkit committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    deb64e5 View commit details
    Browse the repository at this point in the history
  2. r/aws_ebs_volume: Add gp3-specific throughput tests.

    Acceptance test output:
    
    $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_gp3'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_gp3 -timeout 120m
    === RUN   TestAccAWSEBSVolume_gp3_basic
    === PAUSE TestAccAWSEBSVolume_gp3_basic
    === RUN   TestAccAWSEBSVolume_gp3_throughput
    === PAUSE TestAccAWSEBSVolume_gp3_throughput
    === CONT  TestAccAWSEBSVolume_gp3_basic
    === CONT  TestAccAWSEBSVolume_gp3_throughput
    --- PASS: TestAccAWSEBSVolume_gp3_basic (29.45s)
    --- PASS: TestAccAWSEBSVolume_gp3_throughput (52.39s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.448s
    ewbankkit committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    75fe2fc View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. r/aws_ebs_volume: Add CustomizeDiff to validate 'iops' vs. 'type'.

    Acceptance test output:
    
    $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_ -timeout 120m
    === RUN   TestAccAWSEBSVolume_basic
    === PAUSE TestAccAWSEBSVolume_basic
    === RUN   TestAccAWSEBSVolume_updateAttachedEbsVolume
    === PAUSE TestAccAWSEBSVolume_updateAttachedEbsVolume
    === RUN   TestAccAWSEBSVolume_updateSize
    === PAUSE TestAccAWSEBSVolume_updateSize
    === RUN   TestAccAWSEBSVolume_updateType
    === PAUSE TestAccAWSEBSVolume_updateType
    === RUN   TestAccAWSEBSVolume_updateIops_Io1
    === PAUSE TestAccAWSEBSVolume_updateIops_Io1
    === RUN   TestAccAWSEBSVolume_updateIops_Io2
    === PAUSE TestAccAWSEBSVolume_updateIops_Io2
    === RUN   TestAccAWSEBSVolume_kmsKey
    === PAUSE TestAccAWSEBSVolume_kmsKey
    === RUN   TestAccAWSEBSVolume_NoIops
    === PAUSE TestAccAWSEBSVolume_NoIops
    === RUN   TestAccAWSEBSVolume_InvalidIopsForType
    === PAUSE TestAccAWSEBSVolume_InvalidIopsForType
    === RUN   TestAccAWSEBSVolume_withTags
    === PAUSE TestAccAWSEBSVolume_withTags
    === RUN   TestAccAWSEBSVolume_multiAttach
    === PAUSE TestAccAWSEBSVolume_multiAttach
    === RUN   TestAccAWSEBSVolume_outpost
    === PAUSE TestAccAWSEBSVolume_outpost
    === RUN   TestAccAWSEBSVolume_gp3_basic
    === PAUSE TestAccAWSEBSVolume_gp3_basic
    === RUN   TestAccAWSEBSVolume_gp3_throughput
    === PAUSE TestAccAWSEBSVolume_gp3_throughput
    === RUN   TestAccAWSEBSVolume_disappears
    === PAUSE TestAccAWSEBSVolume_disappears
    === CONT  TestAccAWSEBSVolume_basic
    === CONT  TestAccAWSEBSVolume_disappears
    === CONT  TestAccAWSEBSVolume_gp3_throughput
    === CONT  TestAccAWSEBSVolume_gp3_basic
    === CONT  TestAccAWSEBSVolume_outpost
    === CONT  TestAccAWSEBSVolume_multiAttach
    === CONT  TestAccAWSEBSVolume_withTags
    === CONT  TestAccAWSEBSVolume_InvalidIopsForType
    === CONT  TestAccAWSEBSVolume_NoIops
    === CONT  TestAccAWSEBSVolume_kmsKey
    === CONT  TestAccAWSEBSVolume_updateIops_Io2
    === CONT  TestAccAWSEBSVolume_updateIops_Io1
    === CONT  TestAccAWSEBSVolume_updateType
    === CONT  TestAccAWSEBSVolume_updateSize
    === CONT  TestAccAWSEBSVolume_updateAttachedEbsVolume
    === CONT  TestAccAWSEBSVolume_outpost
        data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
    --- SKIP: TestAccAWSEBSVolume_outpost (2.20s)
    --- PASS: TestAccAWSEBSVolume_InvalidIopsForType (16.56s)
    --- PASS: TestAccAWSEBSVolume_disappears (51.43s)
    --- PASS: TestAccAWSEBSVolume_withTags (59.32s)
    --- PASS: TestAccAWSEBSVolume_NoIops (59.53s)
    --- PASS: TestAccAWSEBSVolume_basic (59.58s)
    --- PASS: TestAccAWSEBSVolume_gp3_basic (62.54s)
    --- PASS: TestAccAWSEBSVolume_multiAttach (62.95s)
    --- PASS: TestAccAWSEBSVolume_kmsKey (64.01s)
    --- PASS: TestAccAWSEBSVolume_updateType (90.32s)
    --- PASS: TestAccAWSEBSVolume_gp3_throughput (91.32s)
    --- PASS: TestAccAWSEBSVolume_updateIops_Io2 (91.91s)
    --- PASS: TestAccAWSEBSVolume_updateSize (92.72s)
    --- PASS: TestAccAWSEBSVolume_updateIops_Io1 (92.86s)
    --- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (189.76s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	189.874s
    ewbankkit committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    5f4532a View commit details
    Browse the repository at this point in the history
  2. r/aws_ebs_volume: Add test of IOPS for gp3.

    Acceptance test output:
    
    $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_gp3'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_gp3 -timeout 120m
    === RUN   TestAccAWSEBSVolume_gp3_basic
    === PAUSE TestAccAWSEBSVolume_gp3_basic
    === RUN   TestAccAWSEBSVolume_gp3_iops
    === PAUSE TestAccAWSEBSVolume_gp3_iops
    === RUN   TestAccAWSEBSVolume_gp3_throughput
    === PAUSE TestAccAWSEBSVolume_gp3_throughput
    === CONT  TestAccAWSEBSVolume_gp3_basic
    === CONT  TestAccAWSEBSVolume_gp3_throughput
    === CONT  TestAccAWSEBSVolume_gp3_iops
    --- PASS: TestAccAWSEBSVolume_gp3_basic (31.18s)
    --- PASS: TestAccAWSEBSVolume_gp3_iops (55.62s)
    --- PASS: TestAccAWSEBSVolume_gp3_throughput (55.71s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.751s
    ewbankkit committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    52044ee View commit details
    Browse the repository at this point in the history
  3. d/aws_ebs_volume: Add 'throughput' attribute.

    Acceptance test output:
    
    $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEbsVolumeDataSource_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEbsVolumeDataSource_ -timeout 120m
    === RUN   TestAccAWSEbsVolumeDataSource_basic
    === PAUSE TestAccAWSEbsVolumeDataSource_basic
    === RUN   TestAccAWSEbsVolumeDataSource_multipleFilters
    === PAUSE TestAccAWSEbsVolumeDataSource_multipleFilters
    === CONT  TestAccAWSEbsVolumeDataSource_basic
    === CONT  TestAccAWSEbsVolumeDataSource_multipleFilters
    --- PASS: TestAccAWSEbsVolumeDataSource_basic (25.19s)
    --- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (26.17s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.219s
    ewbankkit committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    09218ce View commit details
    Browse the repository at this point in the history
  4. r/aws_ebs_volume: Remove calls to 'aws.xxxValue()' in 'd.Set()' (hash…

    …icorp#15893).
    
    Acceptance test output:
    
    $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_ -timeout 120m
    === RUN   TestAccAWSEBSVolume_basic
    === PAUSE TestAccAWSEBSVolume_basic
    === RUN   TestAccAWSEBSVolume_updateAttachedEbsVolume
    === PAUSE TestAccAWSEBSVolume_updateAttachedEbsVolume
    === RUN   TestAccAWSEBSVolume_updateSize
    === PAUSE TestAccAWSEBSVolume_updateSize
    === RUN   TestAccAWSEBSVolume_updateType
    === PAUSE TestAccAWSEBSVolume_updateType
    === RUN   TestAccAWSEBSVolume_updateIops_Io1
    === PAUSE TestAccAWSEBSVolume_updateIops_Io1
    === RUN   TestAccAWSEBSVolume_updateIops_Io2
    === PAUSE TestAccAWSEBSVolume_updateIops_Io2
    === RUN   TestAccAWSEBSVolume_kmsKey
    === PAUSE TestAccAWSEBSVolume_kmsKey
    === RUN   TestAccAWSEBSVolume_NoIops
    === PAUSE TestAccAWSEBSVolume_NoIops
    === RUN   TestAccAWSEBSVolume_InvalidIopsForType
    === PAUSE TestAccAWSEBSVolume_InvalidIopsForType
    === RUN   TestAccAWSEBSVolume_withTags
    === PAUSE TestAccAWSEBSVolume_withTags
    === RUN   TestAccAWSEBSVolume_multiAttach
    === PAUSE TestAccAWSEBSVolume_multiAttach
    === RUN   TestAccAWSEBSVolume_outpost
    === PAUSE TestAccAWSEBSVolume_outpost
    === RUN   TestAccAWSEBSVolume_gp3_basic
    === PAUSE TestAccAWSEBSVolume_gp3_basic
    === RUN   TestAccAWSEBSVolume_gp3_iops
    === PAUSE TestAccAWSEBSVolume_gp3_iops
    === RUN   TestAccAWSEBSVolume_gp3_throughput
    === PAUSE TestAccAWSEBSVolume_gp3_throughput
    === RUN   TestAccAWSEBSVolume_disappears
    === PAUSE TestAccAWSEBSVolume_disappears
    === CONT  TestAccAWSEBSVolume_basic
    === CONT  TestAccAWSEBSVolume_withTags
    === CONT  TestAccAWSEBSVolume_disappears
    === CONT  TestAccAWSEBSVolume_gp3_throughput
    === CONT  TestAccAWSEBSVolume_gp3_iops
    === CONT  TestAccAWSEBSVolume_gp3_basic
    === CONT  TestAccAWSEBSVolume_outpost
    === CONT  TestAccAWSEBSVolume_multiAttach
    === CONT  TestAccAWSEBSVolume_updateIops_Io2
    === CONT  TestAccAWSEBSVolume_InvalidIopsForType
    === CONT  TestAccAWSEBSVolume_NoIops
    === CONT  TestAccAWSEBSVolume_kmsKey
    === CONT  TestAccAWSEBSVolume_updateType
    === CONT  TestAccAWSEBSVolume_updateIops_Io1
    === CONT  TestAccAWSEBSVolume_updateSize
    === CONT  TestAccAWSEBSVolume_updateAttachedEbsVolume
    === CONT  TestAccAWSEBSVolume_outpost
        data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
    --- SKIP: TestAccAWSEBSVolume_outpost (2.13s)
    --- PASS: TestAccAWSEBSVolume_InvalidIopsForType (17.40s)
    --- PASS: TestAccAWSEBSVolume_disappears (52.68s)
    --- PASS: TestAccAWSEBSVolume_NoIops (55.37s)
    --- PASS: TestAccAWSEBSVolume_gp3_basic (64.85s)
    --- PASS: TestAccAWSEBSVolume_basic (65.87s)
    --- PASS: TestAccAWSEBSVolume_multiAttach (66.08s)
    --- PASS: TestAccAWSEBSVolume_withTags (66.99s)
    --- PASS: TestAccAWSEBSVolume_kmsKey (67.13s)
    --- PASS: TestAccAWSEBSVolume_updateIops_Io1 (95.66s)
    --- PASS: TestAccAWSEBSVolume_gp3_iops (96.68s)
    --- PASS: TestAccAWSEBSVolume_updateType (98.48s)
    --- PASS: TestAccAWSEBSVolume_updateIops_Io2 (98.71s)
    --- PASS: TestAccAWSEBSVolume_gp3_throughput (99.21s)
    --- PASS: TestAccAWSEBSVolume_updateSize (99.32s)
    --- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (181.29s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	181.371s
    ewbankkit committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    9784e23 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. r/aws_ebs_volume: Throughput is valid only for gp3 volumes.

    Acceptance test output:
    
    $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_InvalidThroughputForType'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_InvalidThroughputForType -timeout 120m
    === RUN   TestAccAWSEBSVolume_InvalidThroughputForType
    === PAUSE TestAccAWSEBSVolume_InvalidThroughputForType
    === CONT  TestAccAWSEBSVolume_InvalidThroughputForType
    --- PASS: TestAccAWSEBSVolume_InvalidThroughputForType (4.68s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.732s
    ewbankkit committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    1216edc View commit details
    Browse the repository at this point in the history