Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Bump Go version to 1.15 and standardize on .go-version file for GitHub Actions workflows #16557

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 3, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/MAINTAINING.md#go-default-version-update
Reference: https://golang.org/doc/go1.15

Release note for CHANGELOG:

provider: The default development, testing, and building of the Terraform AWS Provider binary is now done with Go 1.15. This version of Go now requires macOS 10.12 Sierra or later.

Provider development with Go 1.15 has been very stable the last few months.

Output from acceptance testing: Handled via daily acceptance testing

@bflad bflad requested a review from a team as a code owner December 3, 2020 01:26
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 3, 2020
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@YakDriver YakDriver self-assigned this Dec 4, 2020
@bflad bflad added this to the v3.22.0 milestone Dec 15, 2020
@bflad
Copy link
Contributor Author

bflad commented Dec 15, 2020

This should be okay for the provider release process now.

@bflad bflad merged commit acf1efa into master Dec 15, 2020
@bflad bflad deleted the td-go01.15.5 branch December 15, 2020 14:59
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants