Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sweepers: Allow skipping GuardDuty Detector #16580

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Sweepers: Allow skipping GuardDuty Detector #16580

merged 1 commit into from
Dec 9, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Dec 3, 2020

Skips GuardDuty Detector resources during sweeping on AccessDeniedException error.

Relates #16570

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make sweep SWEEPARGS='-sweep-run=aws_guardduty_detector'

2020/12/03 14:24:10 [DEBUG] Running Sweeper (aws_guardduty_detector) in region (us-west-2)
2020/12/03 14:24:10 [INFO] Deleting GuardDuty Detector: acb123
2020/12/03 14:24:10 [WARN] Skipping GuardDuty Detector (acb123): AccessDeniedException: 
	status code: 403, request id: 
2020/12/03 14:24:10 Sweeper Tests ran successfully:
	- aws_guardduty_detector

@gdavison gdavison requested a review from a team as a code owner December 3, 2020 22:29
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/guardduty Issues and PRs that pertain to the guardduty service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 3, 2020
@gdavison gdavison added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Dec 3, 2020
bflad
bflad approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@gdavison gdavison merged commit 17580c0 into master Dec 9, 2020
@gdavison gdavison deleted the guardduty-detector-sweeper-skip-access-denied branch December 9, 2020 20:34
@ghost
Copy link

ghost commented Jan 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/guardduty Issues and PRs that pertain to the guardduty service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @bflad