[aws_workspaces_directory] Fix Empty Custom Security Group ID & Default OU

[Tensho]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16122

Release note for CHANGELOG:

aws_workspaces_directory: Fix empty custom_security_group_id & default_ou

Unit Tests

$ make test TEST=./aws TESTARGS='-run=TestExpandWorkspaceCreationProperties'
==> Checking that code complies with gofmt requirements...
go test ./aws -run=TestExpandWorkspaceCreationProperties -timeout=5m -parallel=4
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.729s
$ make test TEST=./aws TESTARGS='-run=TestFlattenWorkspaceCreationProperties'
==> Checking that code complies with gofmt requirements...
go test ./aws -run=TestFlattenWorkspaceCreationProperties -timeout=5m -parallel=4
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.002s

Acceptance Tests

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesDirectory_workspaceCreationProperties'
AWS_REGION=us-east-1 make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesDirectory_workspaceCreationProperties'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesDirectory_workspaceCreationProperties -timeout 120m
=== RUN   TestAccAwsWorkspacesDirectory_workspaceCreationProperties
=== PAUSE TestAccAwsWorkspacesDirectory_workspaceCreationProperties
=== RUN   TestAccAwsWorkspacesDirectory_workspaceCreationProperties_customSecurityGroupId_defaultOu
=== PAUSE TestAccAwsWorkspacesDirectory_workspaceCreationProperties_customSecurityGroupId_defaultOu
=== CONT  TestAccAwsWorkspacesDirectory_workspaceCreationProperties
=== CONT  TestAccAwsWorkspacesDirectory_workspaceCreationProperties_customSecurityGroupId_defaultOu
--- PASS: TestAccAwsWorkspacesDirectory_workspaceCreationProperties (1070.72s)
--- PASS: TestAccAwsWorkspacesDirectory_workspaceCreationProperties_customSecurityGroupId_defaultOu (1120.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1123.562s

[DrFaust92]

Minor change in test config. otherwise looks good codewise

[DrFaust92]

LGTM

[ewbankkit]

LGTM.

[breathingdust]

LGTM 🚀 Thanks @Tensho

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesDirectory_workspaceCreationProperties'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesDirectory_workspaceCreationProperties -timeout 120m
=== RUN   TestAccAwsWorkspacesDirectory_workspaceCreationProperties
=== PAUSE TestAccAwsWorkspacesDirectory_workspaceCreationProperties
=== CONT  TestAccAwsWorkspacesDirectory_workspaceCreationProperties
--- PASS: TestAccAwsWorkspacesDirectory_workspaceCreationProperties (787.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	789.385s

[ghost]

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!