Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_schema - new resource #16612

Merged
merged 11 commits into from
Dec 8, 2020
Merged

r/glue_schema - new resource #16612

merged 11 commits into from
Dec 8, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16342

Release note for CHANGELOG:

resource_aws_glue_schema - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueSchema_'
--- PASS: TestAccAWSGlueSchema_disappears_registry (54.12s)
--- PASS: TestAccAWSGlueSchema_disappears (64.55s)
--- PASS: TestAccAWSGlueSchema_basic (83.05s)
--- PASS: TestAccAWSGlueSchema_compatibility (120.69s)
--- PASS: TestAccAWSGlueSchema_description (121.58s)
--- PASS: TestAccAWSGlueSchema_schemaDefUpdated (121.72s)
--- PASS: TestAccAWSGlueSchema_tags (158.50s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner December 6, 2020 10:58
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 6, 2020
@DrFaust92 DrFaust92 marked this pull request as draft December 6, 2020 10:59
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Dec 6, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Dec 6, 2020
@DrFaust92 DrFaust92 marked this pull request as ready for review December 6, 2020 12:20
ewbankkit
ewbankkit reviewed Dec 8, 2020
View reviewed changes
aws/resource_aws_glue_schema.go
update = true
}

if update {
Copy link
Contributor

@ewbankkit ewbankkit Dec 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Could use d.HasChangesExcept("schema_definition", "tags") here.

ewbankkit
ewbankkit approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueSchema_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueSchema_ -timeout 120m
=== RUN   TestAccAWSGlueSchema_basic
=== PAUSE TestAccAWSGlueSchema_basic
=== RUN   TestAccAWSGlueSchema_description
=== PAUSE TestAccAWSGlueSchema_description
=== RUN   TestAccAWSGlueSchema_compatibility
=== PAUSE TestAccAWSGlueSchema_compatibility
=== RUN   TestAccAWSGlueSchema_tags
=== PAUSE TestAccAWSGlueSchema_tags
=== RUN   TestAccAWSGlueSchema_schemaDefUpdated
=== PAUSE TestAccAWSGlueSchema_schemaDefUpdated
=== RUN   TestAccAWSGlueSchema_disappears
=== PAUSE TestAccAWSGlueSchema_disappears
=== RUN   TestAccAWSGlueSchema_disappears_registry
=== PAUSE TestAccAWSGlueSchema_disappears_registry
=== CONT  TestAccAWSGlueSchema_basic
=== CONT  TestAccAWSGlueSchema_schemaDefUpdated
=== CONT  TestAccAWSGlueSchema_disappears_registry
=== CONT  TestAccAWSGlueSchema_disappears
=== CONT  TestAccAWSGlueSchema_compatibility
=== CONT  TestAccAWSGlueSchema_tags
=== CONT  TestAccAWSGlueSchema_description
--- PASS: TestAccAWSGlueSchema_disappears_registry (22.34s)
--- PASS: TestAccAWSGlueSchema_disappears (25.32s)
--- PASS: TestAccAWSGlueSchema_basic (29.83s)
--- PASS: TestAccAWSGlueSchema_compatibility (42.63s)
--- PASS: TestAccAWSGlueSchema_description (46.39s)
--- PASS: TestAccAWSGlueSchema_schemaDefUpdated (46.46s)
--- PASS: TestAccAWSGlueSchema_tags (57.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.752s

@DrFaust92 @ewbankkit
Apply suggestions from code review
7243d6d 
Docs

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueSchema_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueSchema_ -timeout 120m
=== RUN   TestAccAWSGlueSchema_basic
=== PAUSE TestAccAWSGlueSchema_basic
=== RUN   TestAccAWSGlueSchema_description
=== PAUSE TestAccAWSGlueSchema_description
=== RUN   TestAccAWSGlueSchema_compatibility
=== PAUSE TestAccAWSGlueSchema_compatibility
=== RUN   TestAccAWSGlueSchema_tags
=== PAUSE TestAccAWSGlueSchema_tags
=== RUN   TestAccAWSGlueSchema_schemaDefUpdated
=== PAUSE TestAccAWSGlueSchema_schemaDefUpdated
=== RUN   TestAccAWSGlueSchema_disappears
=== PAUSE TestAccAWSGlueSchema_disappears
=== RUN   TestAccAWSGlueSchema_disappears_registry
=== PAUSE TestAccAWSGlueSchema_disappears_registry
=== CONT  TestAccAWSGlueSchema_basic
=== CONT  TestAccAWSGlueSchema_schemaDefUpdated
=== CONT  TestAccAWSGlueSchema_disappears
=== CONT  TestAccAWSGlueSchema_compatibility
=== CONT  TestAccAWSGlueSchema_disappears_registry
=== CONT  TestAccAWSGlueSchema_tags
=== CONT  TestAccAWSGlueSchema_description
--- PASS: TestAccAWSGlueSchema_disappears_registry (13.84s)
2020/12/08 10:09:19 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccAWSGlueSchema_disappears (16.33s)
--- PASS: TestAccAWSGlueSchema_basic (20.30s)
--- PASS: TestAccAWSGlueSchema_compatibility (31.62s)
--- PASS: TestAccAWSGlueSchema_description (31.63s)
--- PASS: TestAccAWSGlueSchema_schemaDefUpdated (34.42s)
--- PASS: TestAccAWSGlueSchema_tags (42.69s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       44.370s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

Skipping as Registry/Schema are not available in GovCloud

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueSchema_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueSchema_ -timeout 120m
=== RUN   TestAccAWSGlueSchema_basic
=== PAUSE TestAccAWSGlueSchema_basic
=== RUN   TestAccAWSGlueSchema_description
=== PAUSE TestAccAWSGlueSchema_description
=== RUN   TestAccAWSGlueSchema_compatibility
=== PAUSE TestAccAWSGlueSchema_compatibility
=== RUN   TestAccAWSGlueSchema_tags
=== PAUSE TestAccAWSGlueSchema_tags
=== RUN   TestAccAWSGlueSchema_schemaDefUpdated
=== PAUSE TestAccAWSGlueSchema_schemaDefUpdated
=== RUN   TestAccAWSGlueSchema_disappears
=== PAUSE TestAccAWSGlueSchema_disappears
=== RUN   TestAccAWSGlueSchema_disappears_registry
=== PAUSE TestAccAWSGlueSchema_disappears_registry
=== CONT  TestAccAWSGlueSchema_basic
=== CONT  TestAccAWSGlueSchema_schemaDefUpdated
=== CONT  TestAccAWSGlueSchema_compatibility
=== CONT  TestAccAWSGlueSchema_disappears_registry
=== CONT  TestAccAWSGlueSchema_description
=== CONT  TestAccAWSGlueSchema_disappears
=== CONT  TestAccAWSGlueSchema_tags
    resource_aws_glue_schema_test.go:295: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueSchema_tags (1.16s)
=== CONT  TestAccAWSGlueSchema_schemaDefUpdated
    resource_aws_glue_schema_test.go:295: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueSchema_schemaDefUpdated (1.16s)
=== CONT  TestAccAWSGlueSchema_description
    resource_aws_glue_schema_test.go:295: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueSchema_description (1.17s)
=== CONT  TestAccAWSGlueSchema_basic
    resource_aws_glue_schema_test.go:295: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueSchema_basic (1.18s)
=== CONT  TestAccAWSGlueSchema_disappears_registry
    resource_aws_glue_schema_test.go:295: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueSchema_disappears_registry (1.19s)
=== CONT  TestAccAWSGlueSchema_compatibility
    resource_aws_glue_schema_test.go:295: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueSchema_compatibility (1.19s)
=== CONT  TestAccAWSGlueSchema_disappears
    resource_aws_glue_schema_test.go:295: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueSchema_disappears (1.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2.833s

@breathingdust breathingdust added this to the v3.21.0 milestone Dec 8, 2020
@breathingdust breathingdust merged commit afa18a2 into hashicorp:master Dec 8, 2020
breathingdust added a commit that referenced this pull request Dec 8, 2020
@breathingdust
Update CHANGELOG.md for #16612
cb4c3cf
@ghost
Copy link

ghost commented Dec 11, 2020

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
@DrFaust92 DrFaust92 deleted the r/glue_schema branch April 15, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.21.0
Development

Successfully merging this pull request may close these issues.

AWS Glue Schema Registry
3 participants
@DrFaust92 @breathingdust @ewbankkit