Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For AWS Service Catalog #1663

Closed
wants to merge 3 commits into from
Closed

Add Support For AWS Service Catalog #1663

wants to merge 3 commits into from

Conversation

bw-intuit
Copy link
Contributor

This is an initial PR to add support for AWS service catalog. Provides resources to manage a portfolio, product and associate them (minimum required functionality for service catalog use).

I will be adding additional resources and capabilities over the next few weeks. I wanted to get early feedback on the code for inclusion.

Thanks

Fixes: hashicorp/terraform#10865

@Ninir
Copy link
Contributor

Ninir commented Sep 18, 2017

Hi @bw-intuit

Thanks for your work: looks amazing :)

I think we should split it in several PRs, for easier code reviews. One for vendoring, one for the main resource, one for another resource, and so on.

What do you think?

Thanks!

@Ninir Ninir added waiting-response Maintainers are waiting on response from community or contributor. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. labels Sep 18, 2017
@bw-intuit
Copy link
Contributor Author

@Ninir sounds good, will submit shortly

@ozbillwang
Copy link

@bw-intuit

Thanks to add this new resource aws_servicecatalog_portfolio. But seems this is only for creating/manage a portfolio.

But how to manage the production, share the portfolio, and others about this service? For example:

create-constraint
create-portfolio (created)
create-portfolio-share
create-product
create-provisioned-product-plan
create-provisioning-artifact
create-service-action

@bw-intuit
Copy link
Contributor Author

@ozbillwang unfortunately I was never able to get this fully merged into the mainline.

I have the following additional resources available on a fork:

https://github.com/bw-intuit/intu-terraform-provider-aws/blob/master/aws/resource_aws_servicecatalog_principal_association_portfolio.go

https://github.com/bw-intuit/intu-terraform-provider-aws/blob/master/aws/resource_aws_servicecatalog_product.go

https://github.com/bw-intuit/intu-terraform-provider-aws/blob/master/aws/resource_aws_servicecatalog_product_association.go

#2064

Unforutnaltey I have moved to another project and won't likely have time to drive getting them merged.

@ozbillwang
Copy link

Thanks, @bw-intuit

looks @trung following it up already. :-)

#4980

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for AWS Service Catalog
4 participants