Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Service: Amazon Connect #16644

Merged
merged 2 commits into from
Dec 15, 2020
Merged

New Service: Amazon Connect #16644

merged 2 commits into from
Dec 15, 2020

Conversation

thornleyk
Copy link
Contributor

@thornleyk thornleyk commented Dec 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Description

This is the initial PR for the Amazon Connect terraform resources. As per contribution guidelines this is only the initial registration of the service client. Following this request, additional resources will be provided. The release log is empty as this PR introduces no client facing resources

Relates #16392

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ go test ./aws
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.921s

This is the initial commit of the Amazon Connect service.
New resources will follow after the initial service merge
@thornleyk thornleyk requested a review from a team as a code owner December 8, 2020 07:13
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Dec 8, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @thornleyk 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@thornleyk thornleyk changed the title New service: Amazon Connect New Service: Amazon Connect Dec 8, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @thornleyk 🚀

@bflad bflad added service/connect Issues and PRs that pertain to the connect service. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 15, 2020
@bflad bflad added this to the v3.22.0 milestone Dec 15, 2020
@bflad bflad merged commit 039fb67 into hashicorp:master Dec 15, 2020
@abebars abebars mentioned this pull request Dec 16, 2020
@thornleyk thornleyk deleted the f-aws_connect_add_service branch December 17, 2020 04:53
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants