Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Adds support for ECS authentication URI for acceptance tests #16679

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Dec 9, 2020

Adds AWS_CONTAINER_CREDENTIALS_FULL_URI as authentication source for acceptance tests.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

N/A

@gdavison gdavison requested a review from a team as a code owner December 9, 2020 20:41
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 9, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gdavison gdavison merged commit 7900b33 into master Dec 9, 2020
@gdavison gdavison deleted the ecs-credentials branch December 9, 2020 22:44
@github-actions github-actions bot added this to the v3.21.0 milestone Dec 9, 2020
@ghost
Copy link

ghost commented Dec 11, 2020

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants