docs/contributing: Add data handling and conversion documentation #16748
+814
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial Contributing Guide documentation on how to handle data and its conversion. Provides a walkthrough of the current Terraform Plugin SDK type system, AWS (API and SDK) type systems, and how to convert between the two. Also includes an initial section on how the maintainers treat sensitive values in terms of the Terraform Plugin SDK implementation that exists today. In the future, this documentation can be augmented with further information on how to handle "nullable" types and other data concerns such as "passthrough" and "virtual" attributes.
ghost
added
size/XL
…ions to match glossary
ewbankkit
added a commit
to ewbankkit/terraform-provider-aws
that referenced
this pull request
Dec 15, 2020
bflad
pushed a commit
that referenced
this pull request
Dec 15, 2020
…tomer_owned_ip attributes (#16723) * d/aws_network_interface: Add 'association.carrier_ip' attribute. * d/aws_network_interface: Move all configurations below acceptance tests. * d/aws_network_interface: Refactor existing acceptance tests before testing new functionality. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsNetworkInterface_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccDataSourceAwsNetworkInterface_ -timeout 120m === RUN TestAccDataSourceAwsNetworkInterface_basic === PAUSE TestAccDataSourceAwsNetworkInterface_basic === RUN TestAccDataSourceAwsNetworkInterface_filters === PAUSE TestAccDataSourceAwsNetworkInterface_filters === CONT TestAccDataSourceAwsNetworkInterface_basic === CONT TestAccDataSourceAwsNetworkInterface_filters --- PASS: TestAccDataSourceAwsNetworkInterface_filters (57.63s) --- PASS: TestAccDataSourceAwsNetworkInterface_basic (57.84s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 57.929s * d/aws_network_interface: Add 'TestAccDataSourceAwsNetworkInterface_EIPAssociation'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsNetworkInterface_EIPAssociation' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccDataSourceAwsNetworkInterface_EIPAssociation -timeout 120m === RUN TestAccDataSourceAwsNetworkInterface_EIPAssociation === PAUSE TestAccDataSourceAwsNetworkInterface_EIPAssociation === CONT TestAccDataSourceAwsNetworkInterface_EIPAssociation --- PASS: TestAccDataSourceAwsNetworkInterface_EIPAssociation (67.86s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 67.946s * d/aws_network_interface: Add 'TestAccDataSourceAwsNetworkInterface_CarrierIPAssociation'. * Fix linter errors. * 'EIPAssociation' -> 'PublicIPAssociation'. * d/aws_network_interface: Add 'association.customer_owned_ip' attribute. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsNetworkInterface_PublicIPAssociation' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsNetworkInterface_PublicIPAssociation -timeout 120m === RUN TestAccDataSourceAwsNetworkInterface_PublicIPAssociation === PAUSE TestAccDataSourceAwsNetworkInterface_PublicIPAssociation === CONT TestAccDataSourceAwsNetworkInterface_PublicIPAssociation --- PASS: TestAccDataSourceAwsNetworkInterface_PublicIPAssociation (67.42s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 67.484s * Modify 'flattenEc2NetworkInterfaceAssociation' to conform to suggested code pattern (#16748).
breathingdust
approved these changes
Dec 16, 2020
ewbankkit
reviewed
Dec 17, 2020
Comment on lines
+549
to
+551
| if v, ok := tfMap["nested_attribute_name"].([]interface{}); ok && len(v) > 0 { | ||
| apiObject.NestedAttributeName = expandServiceStructure(v[0].map[string]interface{}) | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Release note for CHANGELOG:
Initial Contributing Guide documentation on how to handle data and its conversion. Provides a walkthrough of the current Terraform Plugin SDK type system, AWS (API and SDK) type systems, and how to convert between the two. Also includes an initial section on how the maintainers treat sensitive values in terms of the Terraform Plugin SDK implementation that exists today.
In the future, this documentation can be augmented with further information on how to handle "nullable" types and other data concerns such as "passthrough" and "virtual" attributes.
Output from acceptance testing: N/A (documentation)