Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/s3_bucket: Fix lifecycle_rule requirements documentation #16809

Merged
merged 1 commit into from
Dec 18, 2020
Merged

resource/s3_bucket: Fix lifecycle_rule requirements documentation #16809

merged 1 commit into from
Dec 18, 2020

Conversation

lachlancooper
Copy link
Contributor

In #15263, abort_incomplete_multipart_upload_days was added to the set of optional lifecycle_rule arguments of which at least one must be specified. This updates the documentation in line with that change.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15138

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

In #15263, `abort_incomplete_multipart_upload_days` was added to the set
of optional `lifecycle_rule` arguments of which at least one must be
specified.

This updates the documentation in line with that change.
@lachlancooper lachlancooper requested a review from a team as a code owner December 17, 2020 05:36
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. labels Dec 17, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 17, 2020
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Dec 18, 2020
@anGie44 anGie44 added this to the v3.22.0 milestone Dec 18, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @lachlancooper , looks great 🚀

@anGie44 anGie44 merged commit 22c151c into hashicorp:master Dec 18, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants