Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow tagging on ec2 elastic ip #16909

Closed
wants to merge 2 commits into from

Conversation

autotune
Copy link
Contributor

@autotune autotune commented Dec 26, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

#16881

This fixes #16881  and allows tags to be added on create. 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEIP_basic'

@autotune autotune requested a review from a team as a code owner December 26, 2020 20:55
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 26, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 26, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @autotune 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@autotune autotune changed the title [WIP] Allow tagging on git elastic ip [WIP] Allow tagging on ec2 elastic ip Dec 26, 2020
Base automatically changed from master to main January 23, 2021 01:00
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 15, 2021
@ewbankkit
Copy link
Contributor

@autotune Thanks for the contribution.
Since this PR has not been updated in a while I am closing it in favor of the replacement PR #17612.

@ewbankkit ewbankkit closed this Feb 15, 2021
@ghost
Copy link

ghost commented Mar 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants