fix #16917 - changed aws transfer username validation to support 100 chars

[pjanuario]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16917

Release note for CHANGELOG:

BUG FIXES

* resource/aws_transfer_user: Ensure that user is created with more than 32 characters ([#16669](https://github.com/hashicorp/terraform-provider-aws/issues/16669))

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSTransferUser_UserName_Validation'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTransferUser_UserName_Validation -timeout 120m
=== RUN   TestAccAWSTransferUser_UserName_Validation
=== PAUSE TestAccAWSTransferUser_UserName_Validation
=== CONT  TestAccAWSTransferUser_UserName_Validation
--- PASS: TestAccAWSTransferUser_UserName_Validation (34.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.024s

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[pjanuario]

My go skills are a bit rusty so take that in consideration. :)
This PR doesn't change other validations since I don't have any insights on any existing caveats, but from the API documentation I see that are other symbols accepted, I din't added them because could be the case that there is some other limitations.

[pjanuario]

Not sure, what should I do to make the PR pass the failling check.

[bflad]

Looks good, thank you for this update, @pjanuario 🚀

Output from acceptance testing:

--- PASS: TestAccAWSTransferUser_UserName_Validation (17.08s)
--- PASS: TestAccAWSTransferUser_modifyWithOptions (184.32s)
--- PASS: TestAccAWSTransferUser_disappears (190.26s)
--- PASS: TestAccAWSTransferUser_basic (193.45s)
--- PASS: TestAccAWSTransferUser_homeDirectoryMappings (203.67s)

[pjanuario]

@bflad I am not familiar we the provider releases, when is this expected to be released? How can I track this?
Thanks in advance.

[pjanuario]

@bflad I am not familiar we the provider releases, when is this expected to be released? How can I track this?
Thanks in advance.

Forget, I see that you commented in the ticket. Thanks.

[ghost]

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!