Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_route: AWS Wavelength support #16963

Merged
merged 5 commits into from
Mar 26, 2021
Merged

d/aws_route: AWS Wavelength support #16963

merged 5 commits into from
Mar 26, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 4, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14518.

Builds on #14014, #16930, #16961 and #14018.

Release note for CHANGELOG:

data-source/aws_route: Add `carrier_gateway_id` attribute

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.6
=== RUN   TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN   TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN   TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== RUN   TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== RUN   TestAccAWSRouteDataSource_CarrierGatewayID
=== PAUSE TestAccAWSRouteDataSource_CarrierGatewayID
=== CONT  TestAccAWSRouteDataSource_basic
=== CONT  TestAccAWSRouteDataSource_LocalGatewayID
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.32s)
=== CONT  TestAccAWSRouteDataSource_CarrierGatewayID
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (25.47s)
=== CONT  TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (24.72s)
=== CONT  TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_basic (75.27s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (389.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	441.029s

@ewbankkit ewbankkit requested a review from a team as a code owner January 4, 2021 22:21
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 4, 2021
@ewbankkit ewbankkit changed the title [WIP] d/aws_route: AWS Wavelength support d/aws_route: AWS Wavelength support Jan 5, 2021
@ewbankkit ewbankkit force-pushed the d-aws_route-wavelength branch from c7733a2 to 2c52f65 Compare January 6, 2021 14:26
Base automatically changed from master to main January 23, 2021 01:00
@YakDriver YakDriver self-assigned this Mar 25, 2021
@ewbankkit ewbankkit force-pushed the d-aws_route-wavelength branch from 530cfc3 to 04521dc Compare March 26, 2021 18:09
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 26, 2021
ewbankkit and others added 5 commits March 26, 2021 18:34
@ewbankkit @YakDriver
d/aws_route: AWS Wavelength support.
f119734 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 120m
=== RUN   TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN   TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN   TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== RUN   TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== CONT  TestAccAWSRouteDataSource_basic
=== CONT  TestAccAWSRouteDataSource_LocalGatewayID
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (2.00s)
=== CONT  TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (24.28s)
=== CONT  TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_basic (328.90s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (305.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	331.596s
@ewbankkit @YakDriver
d/aws_route: Add 'TestAccAWSRouteDataSource_CarrierGatewayID'.
cf55b56 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_CarrierGatewayID' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_CarrierGatewayID -timeout 120m
=== RUN   TestAccAWSRouteDataSource_CarrierGatewayID
=== PAUSE TestAccAWSRouteDataSource_CarrierGatewayID
=== CONT  TestAccAWSRouteDataSource_CarrierGatewayID
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (25.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.394s
@ewbankkit @YakDriver
Add CHANGELOG entry.
8b7a446
@ewbankkit @YakDriver
Add 'ErrorCheck' for new acceptance tests.
790d401
@YakDriver
ds/route: Minor cleanup
c679cff
@YakDriver YakDriver force-pushed the d-aws_route-wavelength branch from 04521dc to c679cff Compare March 26, 2021 22:38
@YakDriver YakDriver added this to the v3.35.0 milestone Mar 26, 2021
YakDriver
YakDriver approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Acceptance tests in GovCloud:

--- SKIP: TestAccAWSRouteDataSource_CarrierGatewayID (1.63s)
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.86s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (32.00s)
--- PASS: TestAccAWSRouteDataSource_basic (75.12s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (335.09s)

Acceptance tests in commercial:

--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (2.38s)
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (31.74s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (31.87s)
--- PASS: TestAccAWSRouteDataSource_basic (137.66s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (314.49s)

@YakDriver YakDriver merged commit d76c0dc into hashicorp:main Mar 26, 2021
@ewbankkit ewbankkit deleted the d-aws_route-wavelength branch March 27, 2021 11:24
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.

AWS Wavelength support
2 participants
@ewbankkit @YakDriver