Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/config_aggregate_authorization: Fix hardcoded regions #16976

Merged
merged 2 commits into from
Jan 11, 2021
Merged

resource/config_aggregate_authorization: Fix hardcoded regions #16976

merged 2 commits into from
Jan 11, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 5, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995 Phase 2

Release note for CHANGELOG:

NONE

Acceptance Tests in GovCloud

--- PASS: TestAccAWSConfigAggregateAuthorization_basic (16.42s)
--- PASS: TestAccAWSConfigAggregateAuthorization_tags (39.17s)

Acceptance Tests in us-west-2

--- PASS: TestAccAWSConfigAggregateAuthorization_basic (13.36s)
--- PASS: TestAccAWSConfigAggregateAuthorization_tags (30.24s)

@YakDriver YakDriver requested a review from a team as a code owner January 5, 2021 19:54
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 5, 2021
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Jan 5, 2021
@YakDriver YakDriver mentioned this pull request Jan 5, 2021
Closed
@bflad bflad self-assigned this Jan 7, 2021
bflad
bflad reviewed Jan 7, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be simplified with the aws_region data source and resource.TestCheckResourceAttrPair()?

@YakDriver
Copy link
Member Author

Simplified.

GovCloud:

--- PASS: TestAccAWSConfigAggregateAuthorization_basic (16.48s)
--- PASS: TestAccAWSConfigAggregateAuthorization_tags (39.77s)

us-west-2:

--- PASS: TestAccAWSConfigAggregateAuthorization_basic (13.25s)
--- PASS: TestAccAWSConfigAggregateAuthorization_tags (30.81s)

@YakDriver YakDriver requested a review from bflad January 11, 2021 23:29
bflad
bflad approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSConfigAggregateAuthorization_basic (15.51s)
--- PASS: TestAccAWSConfigAggregateAuthorization_tags (33.31s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSConfigAggregateAuthorization_basic (18.78s)
--- PASS: TestAccAWSConfigAggregateAuthorization_tags (43.97s)

@YakDriver YakDriver added this to the v3.24.0 milestone Jan 11, 2021
@YakDriver YakDriver merged commit a241244 into master Jan 11, 2021
@YakDriver YakDriver deleted the t-gov-hardreg-config branch January 11, 2021 23:41
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/configservice Issues and PRs that pertain to the configservice service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @bflad