Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_route53_zone_association: Prevent deletion errors for missing Hosted Zone or VPC association #17023

Merged
merged 1 commit into from
Jan 11, 2021

Commits on Jan 8, 2021

  1. resource/aws_route53_zone_association: Prevent deletion errors for mi…

    …ssing Hosted Zone or VPC association
    
    Reference: #15945
    Reference: #17016
    Reference: https://docs.aws.amazon.com/Route53/latest/APIReference/API_DisassociateVPCFromHostedZone.html#API_DisassociateVPCFromHostedZone_Errors
    
    This is a best effort fix for the errors returned by the Route 53 `DisassociateVPCFromHostedZone` API, which are unrelated to the potential errors during the `Read` function that uses the `ListHostedZonesByVPC` API. The acceptance testing framework does not lend itself well to testing this situation and this highlights a case where #15945 would need special handling.
    
    Output from acceptance testing in AWS Commercial:
    
    ```
    --- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (146.44s)
    --- PASS: TestAccAWSRoute53ZoneAssociation_disappears (147.22s)
    --- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (147.31s)
    --- PASS: TestAccAWSRoute53ZoneAssociation_CrossRegion (149.84s)
    --- PASS: TestAccAWSRoute53ZoneAssociation_basic (150.01s)
    --- PASS: TestAccAWSRoute53ZoneAssociation_CrossAccount (507.91s)
    ```
    bflad committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    0f027e3 View commit details
    Browse the repository at this point in the history