-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_cloudfront_key_group - new resource #17041
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
95d13c4
Define aws_cloudfront_key_group resource
shuheiktgw d1e7ecb
Add tests for aws_cloudfront_key_group resource
shuheiktgw aaa09e4
Add a doc for aws_cloudfront_key_group resource
shuheiktgw 6fa6b9b
Merge branch 'main' of github.com:hashicorp/terraform-provider-aws in…
shuheiktgw a4a0633
Remove the id attribute
shuheiktgw 05ddc58
Improve error handlings
shuheiktgw 5b55171
Miscellaneous changes on the tests
shuheiktgw 5cdd440
Change the format from hcl to terraform
shuheiktgw 92ae055
Add a changelog
shuheiktgw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:new-resource | ||
aws_cloudfront_key_group | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,144 @@ | ||
package aws | ||
|
||
import ( | ||
"fmt" | ||
"log" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/service/cloudfront" | ||
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" | ||
) | ||
|
||
func resourceAwsCloudFrontKeyGroup() *schema.Resource { | ||
return &schema.Resource{ | ||
Create: resourceAwsCloudFrontKeyGroupCreate, | ||
Read: resourceAwsCloudFrontKeyGroupRead, | ||
Update: resourceAwsCloudFrontKeyGroupUpdate, | ||
Delete: resourceAwsCloudFrontKeyGroupDelete, | ||
Importer: &schema.ResourceImporter{ | ||
State: schema.ImportStatePassthrough, | ||
}, | ||
|
||
Schema: map[string]*schema.Schema{ | ||
"comment": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
}, | ||
"etag": { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
}, | ||
"items": { | ||
Type: schema.TypeSet, | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
Set: schema.HashString, | ||
Required: true, | ||
}, | ||
"name": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
func resourceAwsCloudFrontKeyGroupCreate(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).cloudfrontconn | ||
|
||
input := &cloudfront.CreateKeyGroupInput{ | ||
KeyGroupConfig: expandCloudFrontKeyGroupConfig(d), | ||
} | ||
|
||
log.Println("[DEBUG] Create CloudFront Key Group:", input) | ||
|
||
output, err := conn.CreateKeyGroup(input) | ||
if err != nil { | ||
return fmt.Errorf("error creating CloudFront Key Group: %w", err) | ||
} | ||
|
||
if output == nil || output.KeyGroup == nil { | ||
return fmt.Errorf("error creating CloudFront Key Group: empty response") | ||
} | ||
|
||
bflad marked this conversation as resolved.
Show resolved
Hide resolved
|
||
d.SetId(aws.StringValue(output.KeyGroup.Id)) | ||
return resourceAwsCloudFrontKeyGroupRead(d, meta) | ||
} | ||
|
||
func resourceAwsCloudFrontKeyGroupRead(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).cloudfrontconn | ||
input := &cloudfront.GetKeyGroupInput{ | ||
Id: aws.String(d.Id()), | ||
} | ||
|
||
output, err := conn.GetKeyGroup(input) | ||
if err != nil { | ||
if !d.IsNewResource() && isAWSErr(err, cloudfront.ErrCodeNoSuchResource, "") { | ||
log.Printf("[WARN] No key group found: %s, removing from state", d.Id()) | ||
d.SetId("") | ||
return nil | ||
} | ||
return fmt.Errorf("error reading CloudFront Key Group (%s): %w", d.Id(), err) | ||
} | ||
|
||
if output == nil || output.KeyGroup == nil || output.KeyGroup.KeyGroupConfig == nil { | ||
return fmt.Errorf("error reading CloudFront Key Group: empty response") | ||
} | ||
|
||
keyGroupConfig := output.KeyGroup.KeyGroupConfig | ||
|
||
d.Set("name", keyGroupConfig.Name) | ||
d.Set("comment", keyGroupConfig.Comment) | ||
d.Set("items", flattenStringSet(keyGroupConfig.Items)) | ||
d.Set("etag", output.ETag) | ||
|
||
return nil | ||
} | ||
|
||
func resourceAwsCloudFrontKeyGroupUpdate(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).cloudfrontconn | ||
|
||
input := &cloudfront.UpdateKeyGroupInput{ | ||
Id: aws.String(d.Id()), | ||
KeyGroupConfig: expandCloudFrontKeyGroupConfig(d), | ||
IfMatch: aws.String(d.Get("etag").(string)), | ||
} | ||
|
||
_, err := conn.UpdateKeyGroup(input) | ||
if err != nil { | ||
return fmt.Errorf("error updating CloudFront Key Group (%s): %w", d.Id(), err) | ||
} | ||
|
||
return resourceAwsCloudFrontKeyGroupRead(d, meta) | ||
} | ||
|
||
func resourceAwsCloudFrontKeyGroupDelete(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).cloudfrontconn | ||
|
||
input := &cloudfront.DeleteKeyGroupInput{ | ||
Id: aws.String(d.Id()), | ||
IfMatch: aws.String(d.Get("etag").(string)), | ||
} | ||
|
||
_, err := conn.DeleteKeyGroup(input) | ||
if err != nil { | ||
if isAWSErr(err, cloudfront.ErrCodeNoSuchResource, "") { | ||
return nil | ||
} | ||
return fmt.Errorf("error deleting CloudFront Key Group (%s): %w", d.Id(), err) | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func expandCloudFrontKeyGroupConfig(d *schema.ResourceData) *cloudfront.KeyGroupConfig { | ||
keyGroupConfig := &cloudfront.KeyGroupConfig{ | ||
Items: expandStringSet(d.Get("items").(*schema.Set)), | ||
Name: aws.String(d.Get("name").(string)), | ||
} | ||
|
||
if v, ok := d.GetOk("comment"); ok { | ||
keyGroupConfig.Comment = aws.String(v.(string)) | ||
} | ||
|
||
return keyGroupConfig | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can changelog this by adding a
.changelog/17041.txt
file with contents such as: