-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_cloudfront_public_key: Add import support #17044
resource/aws_cloudfront_public_key: Add import support #17044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you, @shuheiktgw 🚀
Output from acceptance testing in AWS Commercial:
--- PASS: TestAccAWSCloudFrontPublicKey_disappears (8.76s)
--- PASS: TestAccAWSCloudFrontPublicKey_basic (11.33s)
--- PASS: TestAccAWSCloudFrontPublicKey_namePrefix (12.19s)
--- PASS: TestAccAWSCloudFrontPublicKey_update (17.59s)
Output from acceptance testing in AWS GovCloud (US):
--- SKIP: TestAccAWSCloudFrontPublicKey_basic (1.36s)
--- SKIP: TestAccAWSCloudFrontPublicKey_disappears (1.36s)
--- SKIP: TestAccAWSCloudFrontPublicKey_namePrefix (1.36s)
--- SKIP: TestAccAWSCloudFrontPublicKey_update (1.36s)
ImportStateVerifyIgnore: []string{ | ||
"name_prefix", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this pull request, but we can support name_prefix
import by adjusting the implementation to the naming
package: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/contribution-checklists.md#adding-resource-name-generation-support 👍
This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Release note for CHANGELOG:
Output from acceptance testing:
Thank you for your review! 👍