Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cloudfront_public_key: Add import support #17044

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

shuheiktgw
Copy link
Collaborator

@shuheiktgw shuheiktgw commented Jan 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_cloudfront_public_key: Add import support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudFrontPublicKey_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontPublicKey_* -timeout 120m
=== RUN   TestAccAWSCloudFrontPublicKey_basic
=== PAUSE TestAccAWSCloudFrontPublicKey_basic
=== RUN   TestAccAWSCloudFrontPublicKey_disappears
=== PAUSE TestAccAWSCloudFrontPublicKey_disappears
=== RUN   TestAccAWSCloudFrontPublicKey_namePrefix
=== PAUSE TestAccAWSCloudFrontPublicKey_namePrefix
=== RUN   TestAccAWSCloudFrontPublicKey_update
=== PAUSE TestAccAWSCloudFrontPublicKey_update
=== CONT  TestAccAWSCloudFrontPublicKey_basic
=== CONT  TestAccAWSCloudFrontPublicKey_update
=== CONT  TestAccAWSCloudFrontPublicKey_disappears
=== CONT  TestAccAWSCloudFrontPublicKey_namePrefix
--- PASS: TestAccAWSCloudFrontPublicKey_disappears (33.45s)
--- PASS: TestAccAWSCloudFrontPublicKey_basic (45.46s)
--- PASS: TestAccAWSCloudFrontPublicKey_namePrefix (45.55s)
--- PASS: TestAccAWSCloudFrontPublicKey_update (69.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	71.962s

Thank you for your review! 👍

@shuheiktgw shuheiktgw requested a review from a team as a code owner January 10, 2021 23:49
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 10, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 10, 2021
Base automatically changed from master to main January 23, 2021 01:00
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 11, 2021
@bflad bflad self-assigned this Feb 11, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you, @shuheiktgw 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSCloudFrontPublicKey_disappears (8.76s)
--- PASS: TestAccAWSCloudFrontPublicKey_basic (11.33s)
--- PASS: TestAccAWSCloudFrontPublicKey_namePrefix (12.19s)
--- PASS: TestAccAWSCloudFrontPublicKey_update (17.59s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSCloudFrontPublicKey_basic (1.36s)
--- SKIP: TestAccAWSCloudFrontPublicKey_disappears (1.36s)
--- SKIP: TestAccAWSCloudFrontPublicKey_namePrefix (1.36s)
--- SKIP: TestAccAWSCloudFrontPublicKey_update (1.36s)

Comment on lines +83 to +85
ImportStateVerifyIgnore: []string{
"name_prefix",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this pull request, but we can support name_prefix import by adjusting the implementation to the naming package: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/contribution-checklists.md#adding-resource-name-generation-support 👍

bflad added a commit that referenced this pull request Feb 11, 2021
@bflad bflad merged commit 7ab054e into hashicorp:main Feb 11, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants