Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_user_profile - new resource #17123

Merged
merged 6 commits into from
Jan 20, 2021
Merged

r/sagemaker_user_profile - new resource #17123

merged 6 commits into from
Jan 20, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 14, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14453

Release note for CHANGELOG:

resource_aws_sagemaker_domain - delete implicit EFS file system
resource_aws_sagemaker_user_profile - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerUserProfile_'
--- PASS: TestAccAWSSagemakerUserProfile_basic (362.62s)
--- PASS: TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings (265.57s)
--- PASS: TestAccAWSSagemakerUserProfile_disappears (377.09s)
--- PASS: TestAccAWSSagemakerUserProfile_jupyterServerAppSettings (325.61s)
--- PASS: TestAccAWSSagemakerUserProfile_tensorboardAppSettings (274.40s)
--- PASS: TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage (335.52s)
--- PASS: TestAccAWSSagemakerUserProfile_tags (357.21s)

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 14, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jan 14, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 14, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review January 14, 2021 22:51
@DrFaust92 DrFaust92 requested a review from a team as a code owner January 14, 2021 22:51
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerUserProfile_' ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSSagemakerUserProfile_ -timeout 120m
=== RUN   TestAccAWSSagemakerUserProfile_basic
=== PAUSE TestAccAWSSagemakerUserProfile_basic
=== RUN   TestAccAWSSagemakerUserProfile_tags
=== PAUSE TestAccAWSSagemakerUserProfile_tags
=== RUN   TestAccAWSSagemakerUserProfile_tensorboardAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_tensorboardAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
=== PAUSE TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
=== RUN   TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_disappears
=== PAUSE TestAccAWSSagemakerUserProfile_disappears
=== CONT  TestAccAWSSagemakerUserProfile_basic
--- PASS: TestAccAWSSagemakerUserProfile_basic (281.59s)
=== CONT  TestAccAWSSagemakerUserProfile_disappears
--- PASS: TestAccAWSSagemakerUserProfile_disappears (250.77s)
=== CONT  TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_jupyterServerAppSettings (283.07s)
=== CONT  TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings (283.22s)
=== CONT  TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
--- PASS: TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage (194.54s)
=== CONT  TestAccAWSSagemakerUserProfile_tensorboardAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_tensorboardAppSettings (210.70s)
=== CONT  TestAccAWSSagemakerUserProfile_tags
--- PASS: TestAccAWSSagemakerUserProfile_tags (252.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1756.184s

ewbankkit
ewbankkit approved these changes Jan 17, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerUserProfile_' ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSSagemakerUserProfile_ -timeout 120m
=== RUN   TestAccAWSSagemakerUserProfile_basic
=== PAUSE TestAccAWSSagemakerUserProfile_basic
=== RUN   TestAccAWSSagemakerUserProfile_tags
=== PAUSE TestAccAWSSagemakerUserProfile_tags
=== RUN   TestAccAWSSagemakerUserProfile_tensorboardAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_tensorboardAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
=== PAUSE TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
=== RUN   TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_disappears
=== PAUSE TestAccAWSSagemakerUserProfile_disappears
=== CONT  TestAccAWSSagemakerUserProfile_basic
--- PASS: TestAccAWSSagemakerUserProfile_basic (303.38s)
=== CONT  TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings (204.26s)
=== CONT  TestAccAWSSagemakerUserProfile_disappears
--- PASS: TestAccAWSSagemakerUserProfile_disappears (380.98s)
=== CONT  TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_jupyterServerAppSettings (199.93s)
=== CONT  TestAccAWSSagemakerUserProfile_tensorboardAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_tensorboardAppSettings (210.40s)
=== CONT  TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
--- PASS: TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage (201.35s)
=== CONT  TestAccAWSSagemakerUserProfile_tags
--- PASS: TestAccAWSSagemakerUserProfile_tags (334.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1834.835s

@DrFaust92 @ewbankkit
Apply suggestions from code review
a4ccf92 
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@DrFaust92 DrFaust92 force-pushed the r/sagemaker_user_profile branch from 2b4b32f to a4ccf92 Compare January 18, 2021 17:23
@DrFaust92
Copy link
Collaborator Author

Rebased onto master

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerUserProfile_' ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSSagemakerUserProfile_ -timeout 120m
=== RUN   TestAccAWSSagemakerUserProfile_basic
=== PAUSE TestAccAWSSagemakerUserProfile_basic
=== RUN   TestAccAWSSagemakerUserProfile_tags
=== PAUSE TestAccAWSSagemakerUserProfile_tags
=== RUN   TestAccAWSSagemakerUserProfile_tensorboardAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_tensorboardAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
=== PAUSE TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
=== RUN   TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
=== PAUSE TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
=== RUN   TestAccAWSSagemakerUserProfile_disappears
=== PAUSE TestAccAWSSagemakerUserProfile_disappears
=== CONT  TestAccAWSSagemakerUserProfile_basic
--- PASS: TestAccAWSSagemakerUserProfile_basic (393.87s)
=== CONT  TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings (313.66s)
=== CONT  TestAccAWSSagemakerUserProfile_disappears
--- PASS: TestAccAWSSagemakerUserProfile_disappears (253.13s)
=== CONT  TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_jupyterServerAppSettings (350.13s)
=== CONT  TestAccAWSSagemakerUserProfile_tensorboardAppSettings
--- PASS: TestAccAWSSagemakerUserProfile_tensorboardAppSettings (187.27s)
=== CONT  TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
--- PASS: TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage (208.58s)
=== CONT  TestAccAWSSagemakerUserProfile_tags
--- PASS: TestAccAWSSagemakerUserProfile_tags (228.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1936.854s

As user profile is part of SageMaker studio, it will not work in GovCloud. A tracking issue will be linked to this PR which will cover updating the tests to SKIP correctly in that partiion.

@breathingdust breathingdust merged commit 1486561 into hashicorp:master Jan 20, 2021
@github-actions github-actions bot added this to the v3.25.0 milestone Jan 20, 2021
breathingdust added a commit that referenced this pull request Jan 20, 2021
@breathingdust
Update CHANGELOG.md for #17123
c577fbe
@breathingdust breathingdust mentioned this pull request Jan 21, 2021
Closed
@ghost
Copy link

ghost commented Jan 22, 2021

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 mentioned this pull request Jan 28, 2021
Closed
@ghost
Copy link

ghost commented Feb 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_user_profile branch April 15, 2021 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.25.0
Development

Successfully merging this pull request may close these issues.

Feature: Support for Sagemaker Studio resources
3 participants
@DrFaust92 @ewbankkit @breathingdust