Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ami: Add owner_id attribute #17178

Merged
merged 1 commit into from
Mar 18, 2021
Merged

resource/aws_ami: Add owner_id attribute #17178

merged 1 commit into from
Mar 18, 2021

Conversation

shuheiktgw
Copy link
Collaborator

@shuheiktgw shuheiktgw commented Jan 20, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16978

Release note for CHANGELOG:

* resource/aws_ami: Add owner_id attribute
* resource/aws_ami_copy: Add owner_id attribute
* resource/aws_ami_from_instance: Add owner_id attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAMI_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMI_ -timeout 120m
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_EphemeralBlockDevices
=== PAUSE TestAccAWSAMI_EphemeralBlockDevices
=== RUN   TestAccAWSAMI_Gp3BlockDevice
=== PAUSE TestAccAWSAMI_Gp3BlockDevice
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_basic
=== CONT  TestAccAWSAMI_Gp3BlockDevice
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_disappears
=== CONT  TestAccAWSAMI_EphemeralBlockDevices
=== CONT  TestAccAWSAMI_description
--- PASS: TestAccAWSAMI_disappears (84.73s)
--- PASS: TestAccAWSAMI_Gp3BlockDevice (93.90s)
--- PASS: TestAccAWSAMI_basic (94.02s)
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (95.49s)
--- PASS: TestAccAWSAMI_description (121.75s)
--- PASS: TestAccAWSAMI_tags (147.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	149.290s

$ make testacc TESTARGS='-run=TestAccAWSAMICopy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMICopy_ -timeout 120m
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_basic
=== CONT  TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_Description
=== CONT  TestAccAWSAMICopy_EnaSupport
--- PASS: TestAccAWSAMICopy_basic (391.30s)
--- PASS: TestAccAWSAMICopy_EnaSupport (391.82s)
--- PASS: TestAccAWSAMICopy_Description (427.53s)
--- PASS: TestAccAWSAMICopy_tags (452.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	454.780s

$ make testacc TESTARGS='-run=TestAccAWSAMIFromInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMIFromInstance_ -timeout 120m
=== RUN   TestAccAWSAMIFromInstance_basic
=== PAUSE TestAccAWSAMIFromInstance_basic
=== RUN   TestAccAWSAMIFromInstance_tags
=== PAUSE TestAccAWSAMIFromInstance_tags
=== CONT  TestAccAWSAMIFromInstance_basic
=== CONT  TestAccAWSAMIFromInstance_tags
--- PASS: TestAccAWSAMIFromInstance_basic (260.20s)
--- PASS: TestAccAWSAMIFromInstance_tags (296.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	298.431s

Thank you for your review! 👍

@shuheiktgw shuheiktgw requested a review from a team as a code owner January 20, 2021 00:00
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 20, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 20, 2021
@shuheiktgw shuheiktgw marked this pull request as draft January 20, 2021 00:10
@shuheiktgw shuheiktgw marked this pull request as ready for review January 20, 2021 07:54
@shuheiktgw shuheiktgw mentioned this pull request Jan 20, 2021
Closed
12 tasks
Base automatically changed from master to main January 23, 2021 01:00
@FireballDWF FireballDWF mentioned this pull request Feb 5, 2021
Closed
ewbankkit
ewbankkit approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_' ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_ -timeout 120m
=== RUN   TestAccAWSAmiDataSource_natInstance
=== PAUSE TestAccAWSAmiDataSource_natInstance
=== RUN   TestAccAWSAmiDataSource_windowsInstance
=== PAUSE TestAccAWSAmiDataSource_windowsInstance
=== RUN   TestAccAWSAmiDataSource_instanceStore
=== PAUSE TestAccAWSAmiDataSource_instanceStore
=== RUN   TestAccAWSAmiDataSource_localNameFilter
=== PAUSE TestAccAWSAmiDataSource_localNameFilter
=== RUN   TestAccAWSAmiDataSource_Gp3BlockDevice
=== PAUSE TestAccAWSAmiDataSource_Gp3BlockDevice
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== RUN   TestAccAWSAMIFromInstance_basic
=== PAUSE TestAccAWSAMIFromInstance_basic
=== RUN   TestAccAWSAMIFromInstance_tags
=== PAUSE TestAccAWSAMIFromInstance_tags
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_EphemeralBlockDevices
=== PAUSE TestAccAWSAMI_EphemeralBlockDevices
=== RUN   TestAccAWSAMI_Gp3BlockDevice
=== PAUSE TestAccAWSAMI_Gp3BlockDevice
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAmiDataSource_natInstance
=== CONT  TestAccAWSAMIFromInstance_basic
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_Gp3BlockDevice
--- PASS: TestAccAWSAmiDataSource_natInstance (14.67s)
=== CONT  TestAccAWSAMI_EphemeralBlockDevices
--- PASS: TestAccAWSAMI_Gp3BlockDevice (58.80s)
=== CONT  TestAccAWSAMI_disappears
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (56.01s)
=== CONT  TestAccAWSAMI_description
--- PASS: TestAccAWSAMI_tags (83.38s)
=== CONT  TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_disappears (54.73s)
=== CONT  TestAccAWSAMIFromInstance_tags
--- PASS: TestAccAWSAMI_description (67.79s)
=== CONT  TestAccAWSAMICopy_basic
--- PASS: TestAccAWSAMI_basic (55.35s)
=== CONT  TestAccAWSAMICopy_tags
--- PASS: TestAccAWSAMIFromInstance_basic (243.56s)
=== CONT  TestAccAWSAMICopy_EnaSupport
--- PASS: TestAccAWSAMIFromInstance_tags (277.72s)
=== CONT  TestAccAWSAMICopy_Description
--- PASS: TestAccAWSAMICopy_basic (381.08s)
=== CONT  TestAccAWSAmiDataSource_localNameFilter
--- PASS: TestAccAWSAmiDataSource_localNameFilter (13.17s)
=== CONT  TestAccAWSAmiDataSource_Gp3BlockDevice
--- PASS: TestAccAWSAMICopy_tags (407.30s)
=== CONT  TestAccAWSAmiDataSource_instanceStore
--- PASS: TestAccAWSAmiDataSource_instanceStore (11.20s)
=== CONT  TestAccAWSAmiDataSource_windowsInstance
--- PASS: TestAccAWSAmiDataSource_windowsInstance (11.85s)
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (54.43s)
--- PASS: TestAccAWSAMICopy_EnaSupport (378.56s)

--- PASS: TestAccAWSAMICopy_Description (382.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	773.664s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @shuheiktgw!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_' ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_ -timeout 120m
=== RUN   TestAccAWSAmiDataSource_natInstance
=== PAUSE TestAccAWSAmiDataSource_natInstance
=== RUN   TestAccAWSAmiDataSource_windowsInstance
=== PAUSE TestAccAWSAmiDataSource_windowsInstance
=== RUN   TestAccAWSAmiDataSource_instanceStore
=== PAUSE TestAccAWSAmiDataSource_instanceStore
=== RUN   TestAccAWSAmiDataSource_localNameFilter
=== PAUSE TestAccAWSAmiDataSource_localNameFilter
=== RUN   TestAccAWSAmiDataSource_Gp3BlockDevice
=== PAUSE TestAccAWSAmiDataSource_Gp3BlockDevice
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== RUN   TestAccAWSAMIFromInstance_basic
=== PAUSE TestAccAWSAMIFromInstance_basic
=== RUN   TestAccAWSAMIFromInstance_tags
=== PAUSE TestAccAWSAMIFromInstance_tags
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_EphemeralBlockDevices
=== PAUSE TestAccAWSAMI_EphemeralBlockDevices
=== RUN   TestAccAWSAMI_Gp3BlockDevice
=== PAUSE TestAccAWSAMI_Gp3BlockDevice
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAmiDataSource_natInstance
=== CONT  TestAccAWSAMIFromInstance_basic
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_disappears
--- PASS: TestAccAWSAmiDataSource_natInstance (17.35s)
=== CONT  TestAccAWSAMI_description
--- PASS: TestAccAWSAMI_disappears (53.46s)
=== CONT  TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_tags (77.47s)
=== CONT  TestAccAWSAMIFromInstance_tags
--- PASS: TestAccAWSAMI_description (63.05s)
=== CONT  TestAccAWSAMI_Gp3BlockDevice
--- PASS: TestAccAWSAMI_basic (52.82s)
=== CONT  TestAccAWSAMI_EphemeralBlockDevices
--- PASS: TestAccAWSAMI_Gp3BlockDevice (52.73s)
=== CONT  TestAccAWSAMICopy_basic
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (53.97s)
=== CONT  TestAccAWSAMICopy_tags
--- PASS: TestAccAWSAMIFromInstance_basic (266.28s)
=== CONT  TestAccAWSAMICopy_EnaSupport
--- PASS: TestAccAWSAMIFromInstance_tags (297.90s)
=== CONT  TestAccAWSAMICopy_Description
--- PASS: TestAccAWSAMICopy_basic (379.45s)
=== CONT  TestAccAWSAmiDataSource_localNameFilter
--- PASS: TestAccAWSAmiDataSource_localNameFilter (13.63s)
=== CONT  TestAccAWSAmiDataSource_Gp3BlockDevice
--- PASS: TestAccAWSAMICopy_tags (390.15s)
=== CONT  TestAccAWSAmiDataSource_instanceStore
--- PASS: TestAccAWSAmiDataSource_instanceStore (12.54s)
=== CONT  TestAccAWSAmiDataSource_windowsInstance
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (50.47s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (13.99s)
--- PASS: TestAccAWSAMICopy_EnaSupport (369.84s)
--- PASS: TestAccAWSAMICopy_Description (379.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	758.484s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_' ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_ -timeout 120m
=== RUN   TestAccAWSAmiDataSource_natInstance
=== PAUSE TestAccAWSAmiDataSource_natInstance
=== RUN   TestAccAWSAmiDataSource_windowsInstance
=== PAUSE TestAccAWSAmiDataSource_windowsInstance
=== RUN   TestAccAWSAmiDataSource_instanceStore
=== PAUSE TestAccAWSAmiDataSource_instanceStore
=== RUN   TestAccAWSAmiDataSource_localNameFilter
=== PAUSE TestAccAWSAmiDataSource_localNameFilter
=== RUN   TestAccAWSAmiDataSource_Gp3BlockDevice
=== PAUSE TestAccAWSAmiDataSource_Gp3BlockDevice
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== RUN   TestAccAWSAMIFromInstance_basic
=== PAUSE TestAccAWSAMIFromInstance_basic
=== RUN   TestAccAWSAMIFromInstance_tags
=== PAUSE TestAccAWSAMIFromInstance_tags
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_EphemeralBlockDevices
=== PAUSE TestAccAWSAMI_EphemeralBlockDevices
=== RUN   TestAccAWSAMI_Gp3BlockDevice
=== PAUSE TestAccAWSAMI_Gp3BlockDevice
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAmiDataSource_natInstance
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAmiDataSource_Gp3BlockDevice
--- PASS: TestAccAWSAmiDataSource_natInstance (11.64s)
=== CONT  TestAccAWSAMICopy_EnaSupport
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (50.94s)
=== CONT  TestAccAWSAMICopy_Description
--- PASS: TestAccAWSAMI_tags (66.76s)
=== CONT  TestAccAWSAMICopy_basic
--- PASS: TestAccAWSAMICopy_EnaSupport (363.58s)
=== CONT  TestAccAWSAMI_description
--- PASS: TestAccAWSAMICopy_tags (381.93s)
=== CONT  TestAccAWSAMI_Gp3BlockDevice
--- PASS: TestAccAWSAMICopy_Description (370.74s)
=== CONT  TestAccAWSAMI_EphemeralBlockDevices
--- PASS: TestAccAWSAMI_Gp3BlockDevice (48.04s)
=== CONT  TestAccAWSAMI_disappears
--- PASS: TestAccAWSAMI_description (55.12s)
=== CONT  TestAccAWSAmiDataSource_instanceStore
--- PASS: TestAccAWSAmiDataSource_instanceStore (8.26s)
=== CONT  TestAccAWSAmiDataSource_localNameFilter
--- PASS: TestAccAWSAMICopy_basic (373.89s)
=== CONT  TestAccAWSAmiDataSource_windowsInstance
--- PASS: TestAccAWSAmiDataSource_localNameFilter (9.79s)
=== CONT  TestAccAWSAMIFromInstance_tags
--- PASS: TestAccAWSAmiDataSource_windowsInstance (8.68s)
=== CONT  TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (48.06s)
=== CONT  TestAccAWSAMIFromInstance_basic
--- PASS: TestAccAWSAMI_disappears (46.41s)
--- PASS: TestAccAWSAMI_basic (47.77s)
--- PASS: TestAccAWSAMIFromInstance_tags (300.39s)
--- PASS: TestAccAWSAMIFromInstance_basic (288.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	760.801s

@breathingdust breathingdust merged commit eb0d46a into hashicorp:main Mar 18, 2021
@YakDriver YakDriver mentioned this pull request Mar 18, 2021
Merged
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuheiktgw @breathingdust @ewbankkit