Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_instance: Added acceptance test when using encrypted volume & IOPS #1728

Merged
merged 3 commits into from
Sep 27, 2017

Conversation

trung
Copy link
Contributor

@trung trung commented Sep 22, 2017

Before PR#1573: failing

After PR#1573:

$ make testacc TESTARGS="-run=TestAccAWSInstance_GP2WithIopsValue"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAWSInstance_GP2WithIopsValue -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_GP2WithIopsValue (80.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	80.071s

@Ninir
Copy link
Contributor

Ninir commented Sep 26, 2017

Hi @trung

Thanks for the suggestion. Could you provide the failing test?

Ran all the tests when merging the related PR, and except one (that is actually a warning) everything was passing.

Thank you! 👍

@Ninir Ninir added the waiting-response Maintainers are waiting on response from community or contributor. label Sep 26, 2017
@trung
Copy link
Contributor Author

trung commented Sep 27, 2017

@Ninir the PR is just a supplement to #1573 as commented (#1573 (comment))

If we didn't have #1573 , the test would fail.

@Ninir Ninir removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 27, 2017
@Ninir Ninir changed the title Added acceptance test for pull/1573 resource/aws_instance: Added acceptance test when using encrypted volume & IOPS Sep 27, 2017
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the work @trung ! 👍

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_GP2WithIopsValue'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSInstance_GP2WithIopsValue -timeout 120m
=== RUN   TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_GP2WithIopsValue (136.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	136.426s

@Ninir Ninir merged commit 8c93067 into hashicorp:master Sep 27, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants