Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_route: 'destination_prefix_list_id' attribute set for managed prefix list destinations #17295

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 26, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Builds on: #14014, #16930, #16961, #17291
Dependents: None (yet)

Relates: #14018, #15273.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 180m
=== RUN   TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN   TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN   TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== RUN   TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== RUN   TestAccAWSRouteDataSource_CarrierGatewayID
=== PAUSE TestAccAWSRouteDataSource_CarrierGatewayID
=== RUN   TestAccAWSRouteDataSource_DestinationPrefixListId
=== PAUSE TestAccAWSRouteDataSource_DestinationPrefixListId
=== RUN   TestAccAWSRouteDataSource_GatewayVpcEndpoint
=== PAUSE TestAccAWSRouteDataSource_GatewayVpcEndpoint
=== CONT  TestAccAWSRouteDataSource_basic
=== CONT  TestAccAWSRouteDataSource_CarrierGatewayID
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (25.83s)
=== CONT  TestAccAWSRouteDataSource_GatewayVpcEndpoint
=== CONT  TestAccAWSRouteDataSource_DestinationPrefixListId
--- PASS: TestAccAWSRouteDataSource_GatewayVpcEndpoint (41.91s)
--- PASS: TestAccAWSRouteDataSource_DestinationPrefixListId (199.51s)
=== CONT  TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (24.39s)
=== CONT  TestAccAWSRouteDataSource_LocalGatewayID
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (0.64s)
=== CONT  TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_basic (305.32s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (378.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	671.027s

@ewbankkit ewbankkit requested a review from a team as a code owner January 26, 2021 23:21
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 26, 2021
@ewbankkit ewbankkit changed the title d/aws_route: 'destination_prefix_list_id' attribute can be specified for managed prefix list destinations [WIP] d/aws_route: 'destination_prefix_list_id' attribute can be specified for managed prefix list destinations Jan 26, 2021
@ewbankkit ewbankkit force-pushed the f-d/aws_route-managed_prefix_list-destination branch from fdf4964 to 0c3a48a Compare January 27, 2021 14:43
rts.Primary.Attributes["id"],
)
}
func TestAccAWSRouteDataSource_GatewayVpcEndpoint(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test validates this change by adding a Gateway VPC Endpoint (S3), specifying that endpoint's prefix list ID to the data source and verifying that no route is returned.

@ewbankkit ewbankkit changed the title [WIP] d/aws_route: 'destination_prefix_list_id' attribute can be specified for managed prefix list destinations d/aws_route: 'destination_prefix_list_id' attribute can be specified for managed prefix list destinations Jan 27, 2021
@ewbankkit

This comment has been minimized.

@ewbankkit ewbankkit changed the title d/aws_route: 'destination_prefix_list_id' attribute can be specified for managed prefix list destinations d/aws_route: 'destination_prefix_list_id' attribute set for managed prefix list destinations Jan 28, 2021
@YakDriver YakDriver self-assigned this Mar 25, 2021
@ewbankkit ewbankkit force-pushed the f-d/aws_route-managed_prefix_list-destination branch 2 times, most recently from 2aad0e1 to 00b90ef Compare March 27, 2021 21:55
@ewbankkit
Copy link
Contributor Author

The XAT001: missing ErrorCheck linter errors should be resolved once #17291 is merged and this PR is rebased.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_DestinationPrefixListId' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_DestinationPrefixListId -timeout 120m
=== RUN   TestAccAWSRouteDataSource_DestinationPrefixListId
=== PAUSE TestAccAWSRouteDataSource_DestinationPrefixListId
=== CONT  TestAccAWSRouteDataSource_DestinationPrefixListId
--- PASS: TestAccAWSRouteDataSource_DestinationPrefixListId (220.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	220.742s
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 180m
=== RUN   TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN   TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN   TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== RUN   TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== RUN   TestAccAWSRouteDataSource_CarrierGatewayID
=== PAUSE TestAccAWSRouteDataSource_CarrierGatewayID
=== RUN   TestAccAWSRouteDataSource_DestinationPrefixListId
=== PAUSE TestAccAWSRouteDataSource_DestinationPrefixListId
=== RUN   TestAccAWSRouteDataSource_GatewayVpcEndpoint
=== PAUSE TestAccAWSRouteDataSource_GatewayVpcEndpoint
=== CONT  TestAccAWSRouteDataSource_basic
=== CONT  TestAccAWSRouteDataSource_CarrierGatewayID
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (26.22s)
=== CONT  TestAccAWSRouteDataSource_GatewayVpcEndpoint
--- PASS: TestAccAWSRouteDataSource_GatewayVpcEndpoint (44.20s)
=== CONT  TestAccAWSRouteDataSource_DestinationPrefixListId
--- PASS: TestAccAWSRouteDataSource_basic (109.30s)
=== CONT  TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (24.56s)
=== CONT  TestAccAWSRouteDataSource_LocalGatewayID
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (0.59s)
=== CONT  TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_DestinationPrefixListId (220.48s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (390.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	524.910s
@ewbankkit ewbankkit force-pushed the f-d/aws_route-managed_prefix_list-destination branch from 00b90ef to 4964548 Compare March 29, 2021 18:26
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 29, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Acceptance tests in commercial:

--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.39s)
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (25.22s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (25.27s)
--- PASS: TestAccAWSRouteDataSource_GatewayVpcEndpoint (41.80s)
--- PASS: TestAccAWSRouteDataSource_basic (89.40s)
--- PASS: TestAccAWSRouteDataSource_DestinationPrefixListId (219.00s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (380.64s)

Acceptance tests in GovCloud:

--- SKIP: TestAccAWSRouteDataSource_DestinationPrefixListId (1.59s)
--- SKIP: TestAccAWSRouteDataSource_CarrierGatewayID (1.61s)
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.86s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (27.01s)
--- PASS: TestAccAWSRouteDataSource_GatewayVpcEndpoint (44.53s)
--- PASS: TestAccAWSRouteDataSource_basic (111.36s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (351.68s)

@YakDriver YakDriver added this to the v3.35.0 milestone Mar 29, 2021
@YakDriver YakDriver merged commit e19a646 into hashicorp:main Mar 29, 2021
@ewbankkit ewbankkit deleted the f-d/aws_route-managed_prefix_list-destination branch March 30, 2021 11:40
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 29, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants