r/aws_sns_topic_subscription: add firehose protocol support

[chammock]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17303

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAWSSNSTopicSubscription_firehose'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicSubscription_firehose -timeout 120m
=== RUN   TestAccAWSSNSTopicSubscription_firehose
=== PAUSE TestAccAWSSNSTopicSubscription_firehose
=== CONT  TestAccAWSSNSTopicSubscription_firehose
--- PASS: TestAccAWSSNSTopicSubscription_firehose (77.80s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       77.916s
...

[github-actions]

Welcome @chammock 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[YakDriver]

@chammock Thank you for this PR! This may be partially superceded by #14923. However, I would like be able to use your acceptance test and for you to get credit. Let me see if I can bring out the inner Git ninja.

[chammock]

@YakDriver That would be awesome to get these merged. I did notice the other MR added firehose as a protocol however the subscription_role_arn was not added as an attribute and that is required for firehose. Any way we can merge these changes together?

[ghost]

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!