resource/aws_spot_instance_request: Add support for instance_interruption_behaviour #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_behaviour Fixes: hashicorp#1719 This has a dependency on hashicorp#1734 to be merged first due to it using the new SDK behaviour ``` === RUN TestAccAWSSpotInstanceRequest_basic --- PASS: TestAccAWSSpotInstanceRequest_basic (87.41s) === RUN TestAccAWSSpotInstanceRequest_withLaunchGroup --- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (86.44s) === RUN TestAccAWSSpotInstanceRequest_withBlockDuration --- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (98.23s) ```
stack72
force-pushed
the
f-aws-spot-instance-instance-interuption-1719
branch
from
ccf3f81
to
5d6ba9d
Compare
radeksimko
added
the
enhancement
|
Has anyone tested that this works? I was hoping to see a test for the stopped side as well but don't see one there. Testing it now I'm getting: I'm not specifying a placement group but looking at the code at https://github.com/terraform-providers/terraform-provider-aws/blob/aa626d6ac98b2ae0c9a8281209cdbc65900d9e5c/aws/resource_aws_instance.go#L1596-L1599 it looks like it might be being set but passed as an empty string anyway? |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1719
I believe the acceptance test failure above is unrelated