Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/contributing: Update invalid S3 bucket name and add note for bucket policy size. #17526

Merged
merged 2 commits into from
Feb 11, 2021
Merged

docs/contributing: Update invalid S3 bucket name and add note for bucket policy size. #17526

merged 2 commits into from
Feb 11, 2021

Conversation

pradeepbhadani
Copy link
Contributor

As per https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html, S3 bucket name cannot have underscores (_).

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@pradeepbhadani pradeepbhadani requested a review from a team as a code owner February 9, 2021 12:13
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. labels Feb 9, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 9, 2021
@pradeepbhadani pradeepbhadani changed the title Update invalid S3 bucket name and add note for bucket policy size. docs/contributing: Update invalid S3 bucket name and add note for bucket policy size. Feb 9, 2021
@breathingdust
Copy link
Member

LGTM! Thanks @pradeepbhadani 🚀

@breathingdust breathingdust merged commit 23a0e73 into hashicorp:main Feb 11, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@pradeepbhadani pradeepbhadani deleted the fix/s3_bucket_policy_doc branch February 12, 2021 21:37
@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pradeepbhadani @breathingdust