Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for cloudfront_distribution resource #17637

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Update docs for cloudfront_distribution resource #17637

merged 1 commit into from
Feb 17, 2021

Conversation

JamesJJ
Copy link
Contributor

@JamesJJ JamesJJ commented Feb 16, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Docs updates for cloudfront_distribution resource:

  1. Cache behavior argument forwarded_values is no longer "required": You can specify either forwarded_values or cache_policy_id as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-defaultcachebehavior.html (Corresponds to changes merged in CloudFront Cache Policy #17336)

  2. Link to the config block description in lambda_function_association, and put the quantity limit inside parentheses to match the rest of the page.

  3. Document missing origin_request_policy_id config item, similar to existing cache_policy_id. Relates to CloudFront Origin Request Policy #17342

@JamesJJ JamesJJ requested a review from a team as a code owner February 16, 2021 14:24
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Feb 16, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 16, 2021
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Feb 17, 2021
@anGie44 anGie44 added this to the v3.29.0 milestone Feb 17, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @JamesJJ , looks great! 🚀

@anGie44 anGie44 merged commit 3feb1df into hashicorp:main Feb 17, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2021
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants