Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/ses_receipt_rule - add encoding + tests #17654

Merged
merged 10 commits into from
Apr 29, 2021
Merged

r/ses_receipt_rule - add encoding + tests #17654

merged 10 commits into from
Apr 29, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Feb 17, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10855
Closes #8605

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSESReceiptRule_'
--- PASS: TestAccAWSSESReceiptRule_stopAction (188.97s)
--- PASS: TestAccAWSSESReceiptRule_basic (229.48s)
--- PASS: TestAccAWSSESReceiptRule_snsAction (267.54s)
--- PASS: TestAccAWSSESReceiptRule_snsActionEncoding (273.15s)
--- PASS: TestAccAWSSESReceiptRule_order (370.68s)
--- PASS: TestAccAWSSESReceiptRule_disappears (391.07s)
--- PASS: TestAccAWSSESReceiptRule_actions (415.14s)
--- PASS: TestAccAWSSESReceiptRule_lambdaAction (454.19s)
--- PASS: TestAccAWSSESReceiptRule_s3Action (548.22s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner February 17, 2021 08:22
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 17, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 17, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Mar 10, 2021
@ewbankkit ewbankkit self-assigned this Apr 29, 2021
ewbankkit
ewbankkit approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESReceiptRule_'                             
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESReceiptRule_ -timeout 180m
=== RUN   TestAccAWSSESReceiptRule_basic
=== PAUSE TestAccAWSSESReceiptRule_basic
=== RUN   TestAccAWSSESReceiptRule_s3Action
=== PAUSE TestAccAWSSESReceiptRule_s3Action
=== RUN   TestAccAWSSESReceiptRule_snsAction
=== PAUSE TestAccAWSSESReceiptRule_snsAction
=== RUN   TestAccAWSSESReceiptRule_snsActionEncoding
=== PAUSE TestAccAWSSESReceiptRule_snsActionEncoding
=== RUN   TestAccAWSSESReceiptRule_lambdaAction
=== PAUSE TestAccAWSSESReceiptRule_lambdaAction
=== RUN   TestAccAWSSESReceiptRule_stopAction
=== PAUSE TestAccAWSSESReceiptRule_stopAction
=== RUN   TestAccAWSSESReceiptRule_order
=== PAUSE TestAccAWSSESReceiptRule_order
=== RUN   TestAccAWSSESReceiptRule_actions
=== PAUSE TestAccAWSSESReceiptRule_actions
=== RUN   TestAccAWSSESReceiptRule_disappears
=== PAUSE TestAccAWSSESReceiptRule_disappears
=== CONT  TestAccAWSSESReceiptRule_basic
=== CONT  TestAccAWSSESReceiptRule_snsActionEncoding
=== CONT  TestAccAWSSESReceiptRule_stopAction
=== CONT  TestAccAWSSESReceiptRule_actions
=== CONT  TestAccAWSSESReceiptRule_snsAction
=== CONT  TestAccAWSSESReceiptRule_lambdaAction
=== CONT  TestAccAWSSESReceiptRule_order
=== CONT  TestAccAWSSESReceiptRule_disappears
=== CONT  TestAccAWSSESReceiptRule_s3Action
--- PASS: TestAccAWSSESReceiptRule_basic (19.55s)
--- PASS: TestAccAWSSESReceiptRule_actions (20.93s)
--- PASS: TestAccAWSSESReceiptRule_snsActionEncoding (21.42s)
--- PASS: TestAccAWSSESReceiptRule_snsAction (22.28s)
--- PASS: TestAccAWSSESReceiptRule_stopAction (22.61s)
--- PASS: TestAccAWSSESReceiptRule_order (22.96s)
--- PASS: TestAccAWSSESReceiptRule_disappears (28.77s)
--- PASS: TestAccAWSSESReceiptRule_s3Action (33.24s)
--- PASS: TestAccAWSSESReceiptRule_lambdaAction (37.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.572s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESReceiptRule_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESReceiptRule_ -timeout 180m
=== RUN   TestAccAWSSESReceiptRule_basic
=== PAUSE TestAccAWSSESReceiptRule_basic
=== RUN   TestAccAWSSESReceiptRule_s3Action
=== PAUSE TestAccAWSSESReceiptRule_s3Action
=== RUN   TestAccAWSSESReceiptRule_snsAction
=== PAUSE TestAccAWSSESReceiptRule_snsAction
=== RUN   TestAccAWSSESReceiptRule_snsActionEncoding
=== PAUSE TestAccAWSSESReceiptRule_snsActionEncoding
=== RUN   TestAccAWSSESReceiptRule_lambdaAction
=== PAUSE TestAccAWSSESReceiptRule_lambdaAction
=== RUN   TestAccAWSSESReceiptRule_stopAction
=== PAUSE TestAccAWSSESReceiptRule_stopAction
=== RUN   TestAccAWSSESReceiptRule_order
=== PAUSE TestAccAWSSESReceiptRule_order
=== RUN   TestAccAWSSESReceiptRule_actions
=== PAUSE TestAccAWSSESReceiptRule_actions
=== RUN   TestAccAWSSESReceiptRule_disappears
=== PAUSE TestAccAWSSESReceiptRule_disappears
=== CONT  TestAccAWSSESReceiptRule_basic
=== CONT  TestAccAWSSESReceiptRule_stopAction
=== CONT  TestAccAWSSESReceiptRule_lambdaAction
=== CONT  TestAccAWSSESReceiptRule_order
=== CONT  TestAccAWSSESReceiptRule_snsActionEncoding
=== CONT  TestAccAWSSESReceiptRule_s3Action
=== CONT  TestAccAWSSESReceiptRule_disappears
=== CONT  TestAccAWSSESReceiptRule_snsAction
=== CONT  TestAccAWSSESReceiptRule_actions
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: a915d10d-ecec-4b6c-acb4-adc1958222a6
--- SKIP: TestAccAWSSESReceiptRule_actions (2.08s)
=== CONT  TestAccAWSSESReceiptRule_s3Action
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: de23c9ee-9e3f-46a7-ab9c-ed35ab0cc362
--- SKIP: TestAccAWSSESReceiptRule_s3Action (2.09s)
=== CONT  TestAccAWSSESReceiptRule_snsActionEncoding
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: 8d7ca5f0-b2d0-45dd-9eaa-046ba1eb400f
--- SKIP: TestAccAWSSESReceiptRule_snsActionEncoding (2.11s)
=== CONT  TestAccAWSSESReceiptRule_disappears
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: c436b7cd-4d61-472a-b581-21e65388ab34
--- SKIP: TestAccAWSSESReceiptRule_disappears (2.12s)
=== CONT  TestAccAWSSESReceiptRule_snsAction
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: e753fd65-97a2-45b1-a504-44bc51686e1c
--- SKIP: TestAccAWSSESReceiptRule_snsAction (2.14s)
=== CONT  TestAccAWSSESReceiptRule_basic
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: a1b19f9d-af46-489c-b61b-75e6d49f840a
--- SKIP: TestAccAWSSESReceiptRule_basic (2.18s)
=== CONT  TestAccAWSSESReceiptRule_lambdaAction
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: 69b02373-3b56-4868-a773-711d71ce7afc
--- SKIP: TestAccAWSSESReceiptRule_lambdaAction (2.19s)
=== CONT  TestAccAWSSESReceiptRule_stopAction
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: 640c5736-18c2-4bd3-b65e-bf8dd1667801
--- SKIP: TestAccAWSSESReceiptRule_stopAction (2.39s)
=== CONT  TestAccAWSSESReceiptRule_order
    resource_aws_ses_receipt_rule_test.go:438: skipping acceptance testing: InvalidAction: Unavailable Operation
        	status code: 400, request id: 9faf3f07-2c8b-4bd4-8370-8054716c930b
--- SKIP: TestAccAWSSESReceiptRule_order (2.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	5.575s

@ewbankkit ewbankkit merged commit b6d154d into hashicorp:main Apr 29, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
@DrFaust92 DrFaust92 deleted the r/ses_receipt_rule_encoding branch May 31, 2021 05:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.

aws_ses_receipt_rule missing SNS Encoding property
2 participants
@DrFaust92 @ewbankkit