Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_vpc_dhcp_options: Correct the ARN account id #17758

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16978

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDHCPOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDHCPOptions_ -timeout 120m
=== RUN   TestAccAWSDHCPOptions_basic
=== PAUSE TestAccAWSDHCPOptions_basic
=== RUN   TestAccAWSDHCPOptions_deleteOptions
=== PAUSE TestAccAWSDHCPOptions_deleteOptions
=== RUN   TestAccAWSDHCPOptions_tags
=== PAUSE TestAccAWSDHCPOptions_tags
=== RUN   TestAccAWSDHCPOptions_disappears
=== PAUSE TestAccAWSDHCPOptions_disappears
=== CONT  TestAccAWSDHCPOptions_basic
=== CONT  TestAccAWSDHCPOptions_disappears
=== CONT  TestAccAWSDHCPOptions_tags
=== CONT  TestAccAWSDHCPOptions_deleteOptions
--- PASS: TestAccAWSDHCPOptions_disappears (33.97s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (35.68s)
--- PASS: TestAccAWSDHCPOptions_basic (45.99s)
--- PASS: TestAccAWSDHCPOptions_tags (92.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	94.316s

$ make testacc TESTARGS='-run=TestAccDataSourceAwsVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsVpcDhcpOptions_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_basic
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_basic
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_Filter
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_Filter
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_basic
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (37.38s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (57.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.894s

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 23, 2021 02:16
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 23, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 23, 2021
@ewbankkit
Copy link
Contributor

@shuheiktgw Thanks for the contribution.
Could you please also update this documentation in website/docs/index.html.markdown to remove the affected resources and data sources.

@ghost ghost added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 24, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_basic
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_basic
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_Filter
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_Filter
=== RUN   TestAccAWSDHCPOptions_basic
=== PAUSE TestAccAWSDHCPOptions_basic
=== RUN   TestAccAWSDHCPOptions_deleteOptions
=== PAUSE TestAccAWSDHCPOptions_deleteOptions
=== RUN   TestAccAWSDHCPOptions_tags
=== PAUSE TestAccAWSDHCPOptions_tags
=== RUN   TestAccAWSDHCPOptions_disappears
=== PAUSE TestAccAWSDHCPOptions_disappears
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_basic
=== CONT  TestAccAWSDHCPOptions_tags
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (14.90s)
=== CONT  TestAccAWSDHCPOptions_disappears
--- PASS: TestAccAWSDHCPOptions_disappears (9.42s)
=== CONT  TestAccAWSDHCPOptions_basic
--- PASS: TestAccAWSDHCPOptions_tags (32.98s)
=== CONT  TestAccAWSDHCPOptions_deleteOptions
--- PASS: TestAccAWSDHCPOptions_basic (12.85s)
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccAWSDHCPOptions_deleteOptions (10.29s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (22.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.199s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @shuheiktgw !

Verified Acceptance Tests in Commercial (us-west-2)

ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_basic
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_basic
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_Filter
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_Filter
=== RUN   TestAccAWSDHCPOptions_basic
=== PAUSE TestAccAWSDHCPOptions_basic
=== RUN   TestAccAWSDHCPOptions_deleteOptions
=== PAUSE TestAccAWSDHCPOptions_deleteOptions
=== RUN   TestAccAWSDHCPOptions_tags
=== PAUSE TestAccAWSDHCPOptions_tags
=== RUN   TestAccAWSDHCPOptions_disappears
=== PAUSE TestAccAWSDHCPOptions_disappears
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_basic
=== CONT  TestAccAWSDHCPOptions_tags
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (14.92s)
=== CONT  TestAccAWSDHCPOptions_basic
--- PASS: TestAccAWSDHCPOptions_basic (12.26s)
=== CONT  TestAccAWSDHCPOptions_deleteOptions
--- PASS: TestAccAWSDHCPOptions_tags (33.53s)
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccAWSDHCPOptions_deleteOptions (8.92s)
=== CONT  TestAccAWSDHCPOptions_disappears
--- PASS: TestAccAWSDHCPOptions_disappears (8.74s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (22.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.206s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

 ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_basic
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_basic
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_Filter
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_Filter
=== RUN   TestAccAWSDHCPOptions_basic
=== PAUSE TestAccAWSDHCPOptions_basic
=== RUN   TestAccAWSDHCPOptions_deleteOptions
=== PAUSE TestAccAWSDHCPOptions_deleteOptions
=== RUN   TestAccAWSDHCPOptions_tags
=== PAUSE TestAccAWSDHCPOptions_tags
=== RUN   TestAccAWSDHCPOptions_disappears
=== PAUSE TestAccAWSDHCPOptions_disappears
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_basic
=== CONT  TestAccAWSDHCPOptions_tags
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (9.70s)
=== CONT  TestAccAWSDHCPOptions_disappears
--- PASS: TestAccAWSDHCPOptions_disappears (6.10s)
=== CONT  TestAccAWSDHCPOptions_basic
--- PASS: TestAccAWSDHCPOptions_tags (21.02s)
=== CONT  TestAccAWSDHCPOptions_deleteOptions
--- PASS: TestAccAWSDHCPOptions_basic (8.29s)
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccAWSDHCPOptions_deleteOptions (6.19s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (15.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.109s

@breathingdust breathingdust merged commit 8275c97 into hashicorp:main Mar 17, 2021
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants