-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_vpc_dhcp_options: Correct the ARN account id #17758
aws_vpc_dhcp_options: Correct the ARN account id #17758
Conversation
@shuheiktgw Thanks for the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_ -timeout 120m
=== RUN TestAccDataSourceAwsVpcDhcpOptions_basic
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_basic
=== RUN TestAccDataSourceAwsVpcDhcpOptions_Filter
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_Filter
=== RUN TestAccAWSDHCPOptions_basic
=== PAUSE TestAccAWSDHCPOptions_basic
=== RUN TestAccAWSDHCPOptions_deleteOptions
=== PAUSE TestAccAWSDHCPOptions_deleteOptions
=== RUN TestAccAWSDHCPOptions_tags
=== PAUSE TestAccAWSDHCPOptions_tags
=== RUN TestAccAWSDHCPOptions_disappears
=== PAUSE TestAccAWSDHCPOptions_disappears
=== CONT TestAccDataSourceAwsVpcDhcpOptions_basic
=== CONT TestAccAWSDHCPOptions_tags
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (14.90s)
=== CONT TestAccAWSDHCPOptions_disappears
--- PASS: TestAccAWSDHCPOptions_disappears (9.42s)
=== CONT TestAccAWSDHCPOptions_basic
--- PASS: TestAccAWSDHCPOptions_tags (32.98s)
=== CONT TestAccAWSDHCPOptions_deleteOptions
--- PASS: TestAccAWSDHCPOptions_basic (12.85s)
=== CONT TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccAWSDHCPOptions_deleteOptions (10.29s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (22.90s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 60.199s
LGTM 🚀 Thanks @shuheiktgw ! Verified Acceptance Tests in Commercial (us-west-2) ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_ -timeout 120m
=== RUN TestAccDataSourceAwsVpcDhcpOptions_basic
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_basic
=== RUN TestAccDataSourceAwsVpcDhcpOptions_Filter
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_Filter
=== RUN TestAccAWSDHCPOptions_basic
=== PAUSE TestAccAWSDHCPOptions_basic
=== RUN TestAccAWSDHCPOptions_deleteOptions
=== PAUSE TestAccAWSDHCPOptions_deleteOptions
=== RUN TestAccAWSDHCPOptions_tags
=== PAUSE TestAccAWSDHCPOptions_tags
=== RUN TestAccAWSDHCPOptions_disappears
=== PAUSE TestAccAWSDHCPOptions_disappears
=== CONT TestAccDataSourceAwsVpcDhcpOptions_basic
=== CONT TestAccAWSDHCPOptions_tags
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (14.92s)
=== CONT TestAccAWSDHCPOptions_basic
--- PASS: TestAccAWSDHCPOptions_basic (12.26s)
=== CONT TestAccAWSDHCPOptions_deleteOptions
--- PASS: TestAccAWSDHCPOptions_tags (33.53s)
=== CONT TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccAWSDHCPOptions_deleteOptions (8.92s)
=== CONT TestAccAWSDHCPOptions_disappears
--- PASS: TestAccAWSDHCPOptions_disappears (8.74s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (22.51s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 59.206s Verified Acceptance Tests in GovCloud (us-gov-west-1) ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSDHCPOptions_\|TestAccDataSourceAwsVpcDhcpOptions_ -timeout 120m
=== RUN TestAccDataSourceAwsVpcDhcpOptions_basic
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_basic
=== RUN TestAccDataSourceAwsVpcDhcpOptions_Filter
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_Filter
=== RUN TestAccAWSDHCPOptions_basic
=== PAUSE TestAccAWSDHCPOptions_basic
=== RUN TestAccAWSDHCPOptions_deleteOptions
=== PAUSE TestAccAWSDHCPOptions_deleteOptions
=== RUN TestAccAWSDHCPOptions_tags
=== PAUSE TestAccAWSDHCPOptions_tags
=== RUN TestAccAWSDHCPOptions_disappears
=== PAUSE TestAccAWSDHCPOptions_disappears
=== CONT TestAccDataSourceAwsVpcDhcpOptions_basic
=== CONT TestAccAWSDHCPOptions_tags
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (9.70s)
=== CONT TestAccAWSDHCPOptions_disappears
--- PASS: TestAccAWSDHCPOptions_disappears (6.10s)
=== CONT TestAccAWSDHCPOptions_basic
--- PASS: TestAccAWSDHCPOptions_tags (21.02s)
=== CONT TestAccAWSDHCPOptions_deleteOptions
--- PASS: TestAccAWSDHCPOptions_basic (8.29s)
=== CONT TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccAWSDHCPOptions_deleteOptions (6.19s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (15.44s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 44.109s |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #16978
Output from acceptance testing: