-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_aws_ec2_traffic_mirror_session: Correct ARN #17938
resource_aws_ec2_traffic_mirror_session: Correct ARN #17938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TrafficMirrorSession_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2TrafficMirrorSession_ -timeout 120m
=== RUN TestAccAWSEc2TrafficMirrorSession_basic
=== PAUSE TestAccAWSEc2TrafficMirrorSession_basic
=== RUN TestAccAWSEc2TrafficMirrorSession_tags
=== PAUSE TestAccAWSEc2TrafficMirrorSession_tags
=== RUN TestAccAWSEc2TrafficMirrorSession_disappears
=== PAUSE TestAccAWSEc2TrafficMirrorSession_disappears
=== CONT TestAccAWSEc2TrafficMirrorSession_basic
=== CONT TestAccAWSEc2TrafficMirrorSession_disappears
--- PASS: TestAccAWSEc2TrafficMirrorSession_disappears (227.54s)
=== CONT TestAccAWSEc2TrafficMirrorSession_tags
--- PASS: TestAccAWSEc2TrafficMirrorSession_basic (264.19s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_tags (325.77s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 553.408s
LGTM 🚀 Thanks @shuheiktgw! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TrafficMirrorSession_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2TrafficMirrorSession_ -timeout 120m
=== RUN TestAccAWSEc2TrafficMirrorSession_basic
=== PAUSE TestAccAWSEc2TrafficMirrorSession_basic
=== RUN TestAccAWSEc2TrafficMirrorSession_tags
=== PAUSE TestAccAWSEc2TrafficMirrorSession_tags
=== RUN TestAccAWSEc2TrafficMirrorSession_disappears
=== PAUSE TestAccAWSEc2TrafficMirrorSession_disappears
=== CONT TestAccAWSEc2TrafficMirrorSession_basic
=== CONT TestAccAWSEc2TrafficMirrorSession_disappears
--- PASS: TestAccAWSEc2TrafficMirrorSession_disappears (226.24s)
=== CONT TestAccAWSEc2TrafficMirrorSession_tags
--- PASS: TestAccAWSEc2TrafficMirrorSession_basic (253.40s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_tags (273.41s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 502.547s Verified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TrafficMirrorSession_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2TrafficMirrorSession_ -timeout 120m
=== RUN TestAccAWSEc2TrafficMirrorSession_basic
=== PAUSE TestAccAWSEc2TrafficMirrorSession_basic
=== RUN TestAccAWSEc2TrafficMirrorSession_tags
=== PAUSE TestAccAWSEc2TrafficMirrorSession_tags
=== RUN TestAccAWSEc2TrafficMirrorSession_disappears
=== PAUSE TestAccAWSEc2TrafficMirrorSession_disappears
=== CONT TestAccAWSEc2TrafficMirrorSession_basic
=== CONT TestAccAWSEc2TrafficMirrorSession_disappears
--- PASS: TestAccAWSEc2TrafficMirrorSession_disappears (219.69s)
=== CONT TestAccAWSEc2TrafficMirrorSession_tags
--- PASS: TestAccAWSEc2TrafficMirrorSession_basic (248.20s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_tags (267.30s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 489.429s |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #16978
Output from acceptance testing:
Thank you for your review!