r/aws_appconfig_application: add appconfig application resource

[Isaiah-Turner]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11973
This PR also requires #17785, which adds the AppConfig service. This PR has been approved but not merged yet.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAppConfigApplication'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigApplication -timeout 120m
=== RUN   TestAccAWSAppConfigApplication_basic
=== PAUSE TestAccAWSAppConfigApplication_basic
=== RUN   TestAccAWSAppConfigApplication_disappears
=== PAUSE TestAccAWSAppConfigApplication_disappears
=== RUN   TestAccAWSAppConfigApplication_Tags
=== PAUSE TestAccAWSAppConfigApplication_Tags
=== CONT  TestAccAWSAppConfigApplication_basic
=== CONT  TestAccAWSAppConfigApplication_Tags
=== CONT  TestAccAWSAppConfigApplication_disappears
--- PASS: TestAccAWSAppConfigApplication_disappears (23.18s)
--- PASS: TestAccAWSAppConfigApplication_basic (31.79s)
--- PASS: TestAccAWSAppConfigApplication_Tags (66.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.466s

[github-actions]

Welcome @Isaiah-Turner 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[ryandeivert]

hey @Isaiah-Turner -- it looks like the tfproviderdocs check is failing CI due to the addition of AppConfig here: https://github.com/hashicorp/terraform-provider-aws/pull/18032/files#diff-bd005eb95385ff4b55a6dd4a2071211fc9771e71eed7818371c0996a94ed57d4R2

I believe, since AppConfig is just a subset of the SSM service, this should be SSM

you might also want to prefix resources with aws_ssm_appconfig_... instead so they're namespaced properly.

Hoping you can get this in soon, since I would like this support as well! thanks for you work!

EDIT: on second thought -- it looks like AppConfig does in fact have it's own endpoint (appconfig.amazonaws.com) and thus it does have it's own service API separate from ssm.. so.. I think this approach is valid. Instead, I believe the following just needs to be updated to include AppConfig:

https://github.com/hashicorp/terraform-provider-aws/blob/main/website/allowed-subcategories.txt

.. I'm now seeing that the above change is included in #17785 and will resolve this issue :)

good luck!

[ryandeivert]

@Isaiah-Turner I believe if you rebase this then CI will pass and they may take a closer look at it

[anGie44]

Hi @Isaiah-Turner , thank you for raising this PR! Since #19307 cherry-picks all of the commits included in this branch, I'm going to close this PR so we can review the referenced PR and get your work and the additional resource merged into an upcoming release.

Thank you again!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.