Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 16973 - allow for ARNs and partner event bus names #18383

Closed
wants to merge 3 commits into from
Closed

Issue 16973 - allow for ARNs and partner event bus names #18383

wants to merge 3 commits into from

Conversation

mdragilev
Copy link

@mdragilev mdragilev commented Mar 24, 2021

Updated to allow partner names for the AWS Event Bridge as well as allow to use ARNs in place of event bridge names as that works with the AWS CLI.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16973

Output from acceptance testing:

@mdragilev mdragilev requested a review from a team as a code owner March 24, 2021 18:28
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 24, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 24, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mdragilev 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@bflad
Copy link
Contributor

bflad commented Mar 26, 2021

Hi @mdragilev 👋 Thank you for submitting this. It appears this was resolved with #16815, which was released yesterday with version 3.34.0 of the Terraform AWS Provider.

@bflad bflad closed this Mar 26, 2021
@bflad
Copy link
Contributor

bflad commented Mar 26, 2021

Actually, my bad, this is for ARNs as well. I'm going to assign this to @gdavison who is most familiar here.

@bflad bflad reopened this Mar 26, 2021
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Apr 6, 2021
@gdavison
Copy link
Contributor

gdavison commented Apr 6, 2021

This was resolved by #18143, which will be released in v3.36.0 later this week

@gdavison gdavison closed this Apr 6, 2021
@prashant-tyagi-cko
Copy link

This fixed the Eventbus name error but now I get error while setting ID - "error reading CloudWatch Events Rule (aws.partner/appflow/salesforce.com/xxx/foo-eventbus/bar-rule): unexpected format for ID ("aws.partner/appflow/salesforce.com/xxx/foo-eventbus/bar-rule"), expected / or "

@ghost
Copy link

ghost commented May 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cloudwatch_event_rule does not support EventBus ARNs in event_bus_name
4 participants