Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding vpc_id to aws_security_group resource md (fixes #1670) #1843

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Adding vpc_id to aws_security_group resource md (fixes #1670) #1843

merged 1 commit into from
Oct 16, 2017

Conversation

ryno75
Copy link
Contributor

@ryno75 ryno75 commented Oct 9, 2017 •
edited by Ninir
Loading

Fixes #1670

@Ninir Ninir added the bug Addresses a defect in current functionality. label Oct 9, 2017
@radeksimko radeksimko added documentation Introduces or discusses updates to documentation. and removed bug Addresses a defect in current functionality. labels Oct 16, 2017
radeksimko
radeksimko approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@radeksimko radeksimko merged commit c206aec into hashicorp:master Oct 16, 2017
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_security_group documentation and plan validation issues with a non-vpc SG using a protocol value of "-1"
3 participants
@ryno75 @radeksimko @Ninir