Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/vpn_connection_route: Wait until route is available/deleted #1849

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

radeksimko
Copy link
Member

The lack of waiters may cause some confusions and handing over resource when it's actually ready is a convention anyway.

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAWSVpnConnectionRoute_ -timeout 120m
=== RUN   TestAccAWSVpnConnectionRoute_basic
--- PASS: TestAccAWSVpnConnectionRoute_basic (247.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	247.156s

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Oct 10, 2017
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit d40e668 into master Oct 14, 2017
@radeksimko radeksimko deleted the b-vpn-conn-route-waiters branch October 14, 2017 04:31
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants