Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_domain - retention policy for efs file system #18562

Merged
merged 4 commits into from
Jul 15, 2021
Merged

r/sagemaker_domain - retention policy for efs file system #18562

merged 4 commits into from
Jul 15, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 4, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17349

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerDomain_serial/Domain'
--- PASS: TestAccAWSSagemakerDomain_serial (3394.21s)
    --- PASS: TestAccAWSSagemakerDomain_serial/Domain (3394.21s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/basic (411.96s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/disappears (448.80s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tags (318.33s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettings (311.14s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettingsWithImage (354.26s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings (304.79s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/jupyterServerAppSettings (298.59s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/kms (289.33s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/securityGroup (349.54s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/sharingSettings (307.47s)

FYI this is a breaking change.

@DrFaust92 DrFaust92 requested a review from a team as a code owner April 4, 2021 09:43
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 4, 2021
@DrFaust92 DrFaust92 changed the title retention policy for efs file system r/sagemaker_domain - retention policy for efs file system Apr 4, 2021
@DrFaust92 DrFaust92 marked this pull request as draft April 4, 2021 14:37
@ewbankkit ewbankkit assigned ewbankkit and unassigned ewbankkit Apr 4, 2021
@DrFaust92 DrFaust92 force-pushed the r/sagemaker_domain_retain_efs branch from ee0c2cd to 1c21d36 Compare June 28, 2021 15:39
@DrFaust92 DrFaust92 marked this pull request as ready for review June 28, 2021 17:02
ewbankkit
ewbankkit approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSSagemakerDomain_serial/Domain'    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerDomain_serial/Domain -timeout 180m
=== RUN   TestAccAWSSagemakerDomain_serial
=== RUN   TestAccAWSSagemakerDomain_serial/Domain
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/basic
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/tags
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettingsWithImage
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/securityGroup
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/kms
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/sharingSettings
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/disappears
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettings
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings_customImage
    resource_aws_sagemaker_domain_test.go:395: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/jupyterServerAppSettings
--- PASS: TestAccAWSSagemakerDomain_serial (2630.19s)
    --- PASS: TestAccAWSSagemakerDomain_serial/Domain (2630.19s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/basic (270.71s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tags (242.67s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettingsWithImage (300.78s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/securityGroup (277.22s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/kms (270.66s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/sharingSettings (247.93s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/disappears (284.92s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettings (244.69s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings (244.87s)
        --- SKIP: TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings_customImage (0.00s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/jupyterServerAppSettings (245.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2634.201s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a3ede2b into hashicorp:main Jul 15, 2021
@github-actions github-actions bot added this to the v3.50.0 milestone Jul 15, 2021
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_domain_retain_efs branch September 25, 2021 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.50.0
Development

Successfully merging this pull request may close these issues.

Sagemaker Domain - Support retaining EFS File system
2 participants
@DrFaust92 @ewbankkit