Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/redshift: Add sweeper concurrency #18592

Merged
merged 5 commits into from
Apr 7, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 6, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15334

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSRedshiftSnapshotSchedule_withDescription (18.70s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withIdentifierPrefix (18.74s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withMultipleDefinition (30.58s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_basic (30.62s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withTags (30.66s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withForceDestroy (565.91s)

@YakDriver YakDriver requested a review from a team as a code owner April 6, 2021 18:37
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 6, 2021
@bflad bflad self-assigned this Apr 7, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Output from acceptance testing:

--- PASS: TestAccAWSRedshiftSnapshotSchedule_withDescription (14.70s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withIdentifierPrefix (14.74s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_basic (23.30s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withMultipleDefinition (23.54s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withTags (23.81s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withForceDestroy (314.14s)

@YakDriver YakDriver added this to the v3.36.0 milestone Apr 7, 2021
@YakDriver YakDriver merged commit 43a6c88 into main Apr 7, 2021
@YakDriver YakDriver deleted the t-concsweep-redshift-snapshot-schedule branch April 7, 2021 17:14
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/redshift Issues and PRs that pertain to the redshift service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants