Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vendoring for aws service budget #1898

Merged
merged 2 commits into from
Oct 15, 2017

Conversation

xchapter7x
Copy link
Contributor

vendors in the aws sdk package for interacting with the budget api.
using -> % govendor fetch github.com/aws/aws-sdk-go/service/budgets@v1.12.6

precursor to the following feature:
[https://github.com//issues/753]

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but do you mind pulling in a version which matches version of other AWS services we have in place already? i.e. v1.12.8?

Thanks.

@radeksimko radeksimko added dependencies Used to indicate dependency changes. waiting-response Maintainers are waiting on response from community or contributor. labels Oct 15, 2017
@xchapter7x
Copy link
Contributor Author

@radeksimko thats my bad. version is now bumped to 1.12.8

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick reaction. 👍

@radeksimko radeksimko merged commit ca67ee9 into hashicorp:master Oct 15, 2017
@xchapter7x xchapter7x deleted the vendor-budget branch October 15, 2017 19:36
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants