Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot Instance Request: handle "closed" requests #1903

Merged

Conversation

darkowlzz
Copy link
Contributor

For one-time spot instance requests, when the instance is terminated,
the request is automatically marked as "closed" and removed by aws after
some time. This is same as "cancelled" requests. This change handles
"closed" state scenario and treats the request as deleted.

fixes #1327

For one-time spot instance requests, when the instance is terminated,
the request is automatically marked as "closed" and removed by aws after
some time. This is same as "cancelled" requests. This change handles
"closed" state scenario and treats the request as deleted.
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the bugfix @darkowlzz
LGTM. 👍

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Oct 15, 2017
@radeksimko radeksimko merged commit 3089ed0 into hashicorp:master Oct 15, 2017
@magnetik
Copy link

Awesome, thanks !

@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running destroy for for terminated spot
3 participants