Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/db_snapshot: Raise creation timeout to 20mins #1905

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

radeksimko
Copy link
Member

This is to address the following test failure which came out of nightly test run:

=== RUN   TestAccAWSDBSnapshot_basic
--- FAIL: TestAccAWSDBSnapshot_basic (767.41s)
    testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_db_snapshot.test: 1 error(s) occurred:
        
        * aws_db_snapshot.test: timeout while waiting for state to become 'available' (last state: 'creating', timeout: 10m0s)
    testing.go:494: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        

The timeout part of schema is admittedly wrong as the timeout belongs to Create action, not Read, but that's a breaking change we should address in a separate PR as it will also require major version bump.

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Oct 15, 2017
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@radeksimko radeksimko merged commit 595e265 into master Oct 16, 2017
@radeksimko radeksimko deleted the b-db-snapshot-retry-timeout branch October 16, 2017 12:35
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants