-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds handling for new error message seen in us-east-2
#19116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial (us-west-2
)
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3 -timeout 180m
=== RUN TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== CONT TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (242.55s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 245.470s
Commercial (us-east-2
)
% AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3 -timeout 180m
=== RUN TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== CONT TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (218.37s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 221.288s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3 -timeout 180m
=== RUN TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== CONT TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (206.20s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 209.134s
Needs a CHANGELOG entry. |
@gdavison @ewbankkit We are seeing this in EU-WEST-1 but not in AF-SOUTH-1, is this change from AWS side being rolled out for object type FILE_S3 on storage gateway? |
Handling of the error seems fixed but the error about invalid operation still persists with the aws provider. This is observed on existing provisioned storage gateway infrastructure as well as undeployed (still trying to pass PLAN) infrastructure. |
This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Correctly handles new error message returned by the AWS API in
us-east-2
:This operation is not valid for the specified gateway
instead ofThe specified operation is not supported
.Closes #19111
Output from acceptance testing: