Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds handling for new error message seen in us-east-2 #19116

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

gdavison
Copy link
Contributor

Correctly handles new error message returned by the AWS API in us-east-2: This operation is not valid for the specified gateway instead of The specified operation is not supported.

Closes #19111

Output from acceptance testing:

$ AWS_DEFAULT_REGION=us-east-2  make testacc TESTARGS='-run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3'

--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (245.33s)

@gdavison gdavison requested a review from a team as a code owner April 26, 2021 23:18
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Apr 26, 2021
@ewbankkit ewbankkit self-assigned this Apr 27, 2021
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Apr 27, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial (us-west-2)
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3 -timeout 180m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (242.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	245.470s
Commercial (us-east-2)
% AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3 -timeout 180m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (218.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	221.288s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayGateway_GatewayType_FileS3 -timeout 180m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (206.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	209.134s

@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

@gdavison gdavison merged commit 5a2bbcf into main Apr 27, 2021
@gdavison gdavison deleted the storagegateway-s3-err-msg branch April 27, 2021 21:22
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 27, 2021
github-actions bot pushed a commit that referenced this pull request Apr 27, 2021
@nerryc
Copy link

nerryc commented Apr 29, 2021

@gdavison @ewbankkit We are seeing this in EU-WEST-1 but not in AF-SOUTH-1, is this change from AWS side being rolled out for object type FILE_S3 on storage gateway?

@rnebular
Copy link

Handling of the error seems fixed but the error about invalid operation still persists with the aws provider. This is observed on existing provisioned storage gateway infrastructure as well as undeployed (still trying to pass PLAN) infrastructure.

@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_storagegateway_gateway with gateway_type FILE_S3 400 error
4 participants