Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: github.com/aws/aws-sdk-go/service/directconnect #1915

Merged
merged 1 commit into from
Oct 16, 2017
Merged

vendor: github.com/aws/aws-sdk-go/service/directconnect #1915

merged 1 commit into from
Oct 16, 2017

Conversation

radeksimko
Copy link
Member

This is to make review of #876 more sane by reducing LOC. 😅

@radeksimko radeksimko added the dependencies Used to indicate dependency changes. label Oct 16, 2017
Ninir
Ninir approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@radeksimko radeksimko merged commit befa952 into master Oct 16, 2017
@radeksimko radeksimko deleted the vendor-aws-direct-connect branch October 16, 2017 14:58
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ninir Ninir Ninir approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @Ninir