F/resource aws dynamodb table: restore from point in time

[nikhil-goenka]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #4558

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDynamoDbTable_backup_encryption'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDynamoDbTable_backup_encryption -timeout 180m
=== RUN   TestAccAWSDynamoDbTable_backup_encryption
=== PAUSE TestAccAWSDynamoDbTable_backup_encryption
=== CONT  TestAccAWSDynamoDbTable_backup_encryption
--- PASS: TestAccAWSDynamoDbTable_backup_encryption (880.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	884.651s
...

[nikhil-goenka]

Hi Guys,

written a small logic to support restore from point in time in dynamodb, tried to follow the approach from RDS cluster, please let me know if this is the right approach, then I can go ahead and add other test cases

[nikhil-goenka]

@ewbankkit : can you please review it once and let me know if this works ?

[AshishDadhich4h2]

Do you know when do we expect this change to be released in https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dynamodb_table

[AshishDadhich4h2]

@ewbankkit : can you please review it once and let me know if this works ?

Why it's not being merged yet ?

[AshishDadhich4h2]

@ewbankkit would you please provide an update on this?

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[breathingdust]

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

[gdavison]

Thanks for the PR, @nikhil-goenka. I've rebased the PR to account for the refactor in #20000. I've also made some tweaks to the code

Acceptance test results in Commercial partition

--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (43.75s)
--- PASS: TestAccDynamoDBTable_TTL_enabled (126.50s)
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (134.38s)
--- PASS: TestAccDynamoDBTable_basic (134.81s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (201.05s)
--- PASS: TestAccDynamoDBTable_disappears (96.89s)
--- PASS: TestAccDynamoDBTable_enablePITR (232.94s)
--- PASS: TestAccDynamoDBTable_tableClassInfrequentAccess (234.41s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (238.49s)
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (18.38s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (243.03s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (208.63s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (143.11s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (148.57s)
--- PASS: TestAccDynamoDBTable_tags (93.92s)
--- PASS: TestAccDynamoDBTable_encryption (325.08s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (98.44s)
--- PASS: TestAccDynamoDBTable_streamSpecification (103.49s)
--- PASS: TestAccDynamoDBTable_backup_encryption (372.73s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (372.97s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (488.02s)
--- PASS: TestAccDynamoDBTable_extended (490.33s)
--- PASS: TestAccDynamoDBTable_Replica_single (589.03s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (883.17s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (883.84s)
--- PASS: TestAccDynamoDBTable_backup_overrideEncryption (943.43s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (1014.70s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (1122.95s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (1171.49s)

Acceptance test results in GovCloud partition

--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (20.12s)
--- SKIP: TestAccDynamoDBTable_tableClassInfrequentAccess (32.08s)
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (33.73s)
--- PASS: TestAccDynamoDBTable_basic (83.21s)
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (92.32s)
--- PASS: TestAccDynamoDBTable_TTL_enabled (93.74s)
--- PASS: TestAccDynamoDBTable_tags (111.72s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (140.63s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (141.06s)
--- PASS: TestAccDynamoDBTable_streamSpecification (147.79s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (157.28s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (170.10s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (146.78s)
--- PASS: TestAccDynamoDBTable_enablePITR (166.72s)
--- PASS: TestAccDynamoDBTable_disappears (77.04s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (186.07s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (302.40s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (303.36s)
--- PASS: TestAccDynamoDBTable_encryption (320.26s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (242.81s)
--- PASS: TestAccDynamoDBTable_extended (485.38s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (579.89s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (580.11s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (796.83s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (824.41s)
--- PASS: TestAccDynamoDBTable_backup_overrideEncryption (887.01s)
--- PASS: TestAccDynamoDBTable_backup_encryption (889.73s)
--- PASS: TestAccDynamoDBTable_Replica_single (1048.63s)

[github-actions]

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.