Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing interface_type #19492

Merged
merged 5 commits into from
May 24, 2021
Merged

add missing interface_type #19492

merged 5 commits into from
May 24, 2021

Conversation

ghdiska
Copy link
Contributor

@ghdiska ghdiska commented May 24, 2021 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19462.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghdiska ghdiska requested a review from a team as a code owner May 24, 2021 07:45
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. labels May 24, 2021
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. labels May 24, 2021
github-actions[bot]
github-actions bot reviewed May 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ghdiska 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit self-assigned this May 24, 2021
@ewbankkit
Copy link
Contributor

We have a number of failing CI tests related to this bug:

Test ended in panic.
------- Stdout: -------
=== RUN   TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
------- Stderr: -------
panic: Invalid address to set: []string{"network_interfaces", "0", "interface_type"}
goroutine 418 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc0047fef00, 0x827bae5, 0x12, 0x6a3a2c0, 0xc002fb1698, 0x1, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource_data.go:230 +0x371
github.com/terraform-providers/terraform-provider-aws/aws.dataSourceAwsLaunchTemplateRead(0xc0047fef00, 0x7427e20, 0xc002b74000, 0xd0eb8f0, 0xc000051000)
  /opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_launch_template.go:542 +0x1bcf
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc0012cfc00, 0x92f07e8, 0xc0047f5940, 0xc0047fef00, 0x7427e20, 0xc002b74000, 0x0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource.go:335 +0x1ee
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc0012cfc00, 0x92f07e8, 0xc0047f5940, 0xc0025098a0, 0x7427e20, 0xc002b74000, 0xc002b74000, 0xc0025098a0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource.go:558 +0xfd
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0xc002bfc0c0, 0x92f07e8, 0xc0047f5940, 0xc002509440, 0xc0047f5940, 0x40dba5, 0x7d5de80)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/grpc_provider.go:1105 +0x4d6
github.com/hashicorp/terraform-plugin-go/tfprotov5/server.(*server).ReadDataSource(0xc002478140, 0x92f0890, 0xc0047f5940, 0xc002a50910, 0xc002478140, 0xc002a29e60, 0xc003d2aba0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.3.0/tfprotov5/server/server.go:247 +0xe5
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler(0x8030880, 0xc002478140, 0x92f0890, 0xc002a29e60, 0xc002a69620, 0x0, 0x92f0890, 0xc002a29e60, 0xc002a56b40, 0x23f)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.3.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:416 +0x214
google.golang.org/grpc.(*Server).processUnaryRPC(0xc002c18000, 0x931a7b8, 0xc002e12000, 0xc002a7a200, 0xc00257c9c0, 0xd088b70, 0x0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1194 +0x52b
google.golang.org/grpc.(*Server).handleStream(0xc002c18000, 0x931a7b8, 0xc002e12000, 0xc002a7a200, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1517 +0xd0c
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc00207c040, 0xc002c18000, 0x931a7b8, 0xc002e12000, 0xc002a7a200)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:859 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:857 +0x1fd
Test ended in panic.
------- Stdout: -------
=== RUN   TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
------- Stderr: -------
panic: Invalid address to set: []string{"network_interfaces", "0", "interface_type"}
goroutine 420 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc002b34580, 0x827bae5, 0x12, 0x6a3a2c0, 0xc002068000, 0x1, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource_data.go:230 +0x371
github.com/terraform-providers/terraform-provider-aws/aws.dataSourceAwsLaunchTemplateRead(0xc002b34580, 0x7427e20, 0xc001a22c00, 0xd0eb8f0, 0xc000051000)
  /opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_launch_template.go:542 +0x1bcf
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc001340000, 0x92f07e8, 0xc00293a480, 0xc002b34580, 0x7427e20, 0xc001a22c00, 0x0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource.go:335 +0x1ee
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc001340000, 0x92f07e8, 0xc00293a480, 0xc0035d8980, 0x7427e20, 0xc001a22c00, 0xc001a22c00, 0xc0035d8980, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource.go:558 +0xfd
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0xc003cfa4f8, 0x92f07e8, 0xc00293a480, 0xc0035d8520, 0xc00293a480, 0x40dba5, 0x7d5de80)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/grpc_provider.go:1105 +0x4d6
github.com/hashicorp/terraform-plugin-go/tfprotov5/server.(*server).ReadDataSource(0xc0035d81a0, 0x92f0890, 0xc00293a480, 0xc003cbaa50, 0xc0035d81a0, 0xc002b1ecc0, 0xc00008fba0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.3.0/tfprotov5/server/server.go:247 +0xe5
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler(0x8030880, 0xc0035d81a0, 0x92f0890, 0xc002b1ecc0, 0xc003e8c660, 0x0, 0x92f0890, 0xc002b1ecc0, 0xc00391cfc0, 0x23f)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.3.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:416 +0x214
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0022c41c0, 0x931a7b8, 0xc00253f500, 0xc003b4c100, 0xc003f0fe90, 0xd088b70, 0x0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1194 +0x52b
google.golang.org/grpc.(*Server).handleStream(0xc0022c41c0, 0x931a7b8, 0xc00253f500, 0xc003b4c100, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1517 +0xd0c
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc001237620, 0xc0022c41c0, 0x931a7b8, 0xc00253f500, 0xc003b4c100)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:859 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:857 +0x1fd
Test ended in panic.
------- Stdout: -------
=== RUN   TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== PAUSE TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== CONT  TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
------- Stderr: -------
panic: Invalid address to set: []string{"network_interfaces", "0", "interface_type"}
goroutine 419 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc002daa180, 0x827bae5, 0x12, 0x6a3a2c0, 0xc002e6e5b8, 0x1, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource_data.go:230 +0x371
github.com/terraform-providers/terraform-provider-aws/aws.dataSourceAwsLaunchTemplateRead(0xc002daa180, 0x7427e20, 0xc0011fcc00, 0xd0eb8f0, 0xc000051000)
  /opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_launch_template.go:542 +0x1bcf
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc00122bce0, 0x92f07e8, 0xc002d50e00, 0xc002daa180, 0x7427e20, 0xc0011fcc00, 0x0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource.go:335 +0x1ee
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc00122bce0, 0x92f07e8, 0xc002d50e00, 0xc0029f5280, 0x7427e20, 0xc0011fcc00, 0xc0011fcc00, 0xc0029f5280, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/resource.go:558 +0xfd
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0xc0028585b8, 0x92f07e8, 0xc002d50e00, 0xc0029f4ca0, 0xc002d50e00, 0x40dba5, 0x7d5de80)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.6.1/helper/schema/grpc_provider.go:1105 +0x4d6
github.com/hashicorp/terraform-plugin-go/tfprotov5/server.(*server).ReadDataSource(0xc00288a1a0, 0x92f0890, 0xc002d50e00, 0xc002c4dc70, 0xc00288a1a0, 0xc002d9b170, 0xc001f00ba0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.3.0/tfprotov5/server/server.go:247 +0xe5
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler(0x8030880, 0xc00288a1a0, 0x92f0890, 0xc002d9b170, 0xc002d2f4a0, 0x0, 0x92f0890, 0xc002d9b170, 0xc002d2bb00, 0x23f)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.3.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:416 +0x214
google.golang.org/grpc.(*Server).processUnaryRPC(0xc00294ddc0, 0x931a7b8, 0xc001068000, 0xc002c1ce00, 0xc002ed28a0, 0xd088b70, 0x0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1194 +0x52b
google.golang.org/grpc.(*Server).handleStream(0xc00294ddc0, 0x931a7b8, 0xc001068000, 0xc002c1ce00, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1517 +0xd0c
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc002092020, 0xc00294ddc0, 0x931a7b8, 0xc001068000, 0xc002c1ce00)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:859 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:857 +0x1fd

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 24, 2021
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label May 24, 2021
ewbankkit
ewbankkit approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 180m
=== RUN   TestAccAWSLaunchTemplateDataSource_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_id_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_id_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_tags
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_tags
=== RUN   TestAccAWSLaunchTemplateDataSource_metadataOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_metadataOptions
=== RUN   TestAccAWSLaunchTemplateDataSource_enclaveOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_enclaveOptions
=== RUN   TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== RUN   TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== PAUSE TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== RUN   TestAccAWSLaunchTemplateDataSource_NonExistent
=== PAUSE TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== CONT  TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_metadataOptions
=== CONT  TestAccAWSLaunchTemplateDataSource_enclaveOptions
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_tags
=== CONT  TestAccAWSLaunchTemplateDataSource_id_basic
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (4.50s)
--- PASS: TestAccAWSLaunchTemplateDataSource_enclaveOptions (24.84s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (25.04s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (26.15s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (26.26s)
--- PASS: TestAccAWSLaunchTemplateDataSource_id_basic (26.36s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (26.40s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (53.81s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (53.92s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (54.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.322s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 180m
=== RUN   TestAccAWSLaunchTemplateDataSource_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_id_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_id_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_tags
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_tags
=== RUN   TestAccAWSLaunchTemplateDataSource_metadataOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_metadataOptions
=== RUN   TestAccAWSLaunchTemplateDataSource_enclaveOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_enclaveOptions
=== RUN   TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== RUN   TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== PAUSE TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== RUN   TestAccAWSLaunchTemplateDataSource_NonExistent
=== PAUSE TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_metadataOptions
=== CONT  TestAccAWSLaunchTemplateDataSource_id_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_enclaveOptions
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_tags
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (6.43s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (24.66s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (25.17s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (25.55s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (27.13s)
--- PASS: TestAccAWSLaunchTemplateDataSource_id_basic (27.16s)
--- PASS: TestAccAWSLaunchTemplateDataSource_enclaveOptions (27.29s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (58.22s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (58.25s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (58.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.595s

@ewbankkit
Copy link
Contributor

@ghdiska Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4186890 into hashicorp:main May 24, 2021
@github-actions github-actions bot added this to the v3.43.0 milestone May 24, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.43.0
Development

Successfully merging this pull request may close these issues.

data "aws_launch_template" error error setting network_interfaces
2 participants
@ghdiska @ewbankkit