Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws-sdk-go/service/...@v1.12.12 #1950

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Add aws-sdk-go/service/...@v1.12.12 #1950

merged 1 commit into from
Oct 18, 2017

Conversation

handlerbot
Copy link
Contributor

govendor fetch github.com/aws/aws-sdk-go/service/elasticsearchservice@v1.12.12 for #1949

@radeksimko radeksimko added the dependencies Used to indicate dependency changes. label Oct 18, 2017
@radeksimko
Copy link
Member

Hi @handlerbot
we usually upgrade the whole SDK, do you mind doing that?

govendor fetch github.com/aws/aws-sdk-go/...@v1.12.12

Thanks.

@radeksimko radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 18, 2017
@handlerbot
Copy link
Contributor Author

Sure, will do. I was cribbing from #1916, apologies.

@handlerbot handlerbot changed the title Add aws-sdk-go/service/elasticsearchservice@v1.12.12 Add aws-sdk-go/service/...@v1.12.12 Oct 18, 2017
@handlerbot
Copy link
Contributor Author

@radeksimko Ready to go!

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 18, 2017
radeksimko
radeksimko approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

#1916 was adding a new service, rather than upgrading it, so that's different. 😉

@radeksimko radeksimko merged commit d6b12ce into hashicorp:master Oct 18, 2017
@handlerbot handlerbot deleted the vendor-elasticsearch branch October 18, 2017 18:35
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@handlerbot @radeksimko