Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize JSON policy document #1954

Closed
wants to merge 2 commits into from
Closed

Normalize JSON policy document #1954

wants to merge 2 commits into from

Conversation

darkowlzz
Copy link
Contributor

@darkowlzz darkowlzz commented Oct 18, 2017 •
edited
Loading

This change normalizes the provided JSON policy document and uses the
same to create IAM policy and role. Also, the normalized json is indented with 4
spaces.

fixes #1873

@darkowlzz darkowlzz force-pushed the 1873-leading-whitespace-json branch 2 times, most recently from 02fd898 to 915724b Compare October 18, 2017 18:48
@darkowlzz
Copy link
Contributor Author

darkowlzz commented Oct 18, 2017 •
edited
Loading

Maybe a bad idea to change the normalize function 😅 requires changing a lot test cases.

@darkowlzz darkowlzz force-pushed the 1873-leading-whitespace-json branch 5 times, most recently from 13d6c81 to 650e368 Compare October 18, 2017 19:30
@darkowlzz
aws_iam_policy: normalize JSON policy document
5065143 
This change normalizes the provided JSON policy document and uses the
same to create IAM policy.
@darkowlzz
aws_iam_role: normalize JSON policy document
0e5498c
@darkowlzz darkowlzz force-pushed the 1873-leading-whitespace-json branch from 650e368 to 0e5498c Compare October 18, 2017 19:41
@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 21, 2017
@radeksimko radeksimko added the size/L Managed by automation to categorize the size of a PR. label Nov 15, 2017
@bflad bflad added the service/iam Issues and PRs that pertain to the iam service. label Jan 28, 2018
@aeschright aeschright requested a review from a team June 25, 2019 18:42
@bflad
Copy link
Contributor

bflad commented Jan 10, 2020

Hi @darkowlzz 👋 Thank you for submitting this and sorry this pull request was sitting so long without any maintainer review. There have since been a lot of changes to the codebase that have since caused merge conflicts here and potentially changed the implementation details for this, so I'm going to close this for now. If you have the desire to re-submit the changes here, we'll take a fresh look. Thanks again for the contribution.

@bflad bflad closed this Jan 10, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: leading whitespace causes aws_iam_policy to incorrectly report valid JSON policies as invalid
3 participants
@darkowlzz @bflad @radeksimko